Skip to content

clk_phase error caching problems

Stephen Boyd linux-clk lkml 2 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 7 repliesApplied
  2. v11 patch 6 repliesSuperseded

Changes in v2 from the cover letter

* A pile of new patches
* Rebased to clk-next
* New patch to bail out of registration if getting the phase fails

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4clk: Don't cache errors from clk_ops::get_phase()drivers/clk/clk.c+32 -163 replies
2/4clk: Use 'parent' to shorten lines in __clk_core_init()drivers/clk/clk.c+11 -111 reply
3/4clk: Move rate and accuracy recalc to mostly consumer APIsdrivers/clk/clk.c+24 -241 reply
4/4clk: Bail out when calculating phase fails during clk registrationdrivers/clk/clk.c+6 -11 reply

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJerome Brunet
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] clk_phase error caching problems

This patch series is a follow up to[1] which I sent out a few months ago. We no longer cache the clk phase if it's an error value, so that things like debugfs don't return us nonsense values for the phase.

Futhermore, the last patch fixes up the locking so that debugfs code can avoid doing a recursive prepare lock because we know what we're doing in that case. While we get some more functions, we avoid taking the lock again.

Changes from v1:
* A pile of new patches
* Rebased to clk-next
* New patch to bail out of registration if getting the phase fails

Cc Douglas Anderson <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Jerome Brunet <[email protected]>

Stephen Boyd (4):
clk: Don't cache errors from clk_ops::get_phase()
clk: Use 'parent' to shorten lines in __clk_core_init()
clk: Move rate and accuracy recalc to mostly consumer APIs
clk: Bail out when calculating phase fails during clk registration

 drivers/clk/clk.c | 119 +++++++++++++++++++++++++++-------------------
 1 file changed, 70 insertions(+), 49 deletions(-)

[1] https://lkml.kernel.org/r/[email protected]

base-commit: 5df867145f8adad9e5cdf9d67db1fbc0f71351e9

Signature · 1 line
Sent by a computer, using git, on the internet