Skip to content

tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

Jarkko Sakkinen linux-integrity lkml stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 6 repliesIn review
  2. v33 patches 1 replyApplied
  3. v13 patches 2 repliesSuperseded

Changes in v4 from the cover letter

* There was unnecessary assignment inside TPM_CHIP_FLAG_TPM2 branch (does not cause any run-time issue).

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tpm: migrate pubek_show to struct tpm_bufdrivers/char/tpm/tpm-sysfs.c drivers/char/tpm/tpm.h+48 -521 reply
2/3tpm: use tpm_try_get_ops() in tpm-sysfs.c.drivers/char/tpm/tpm-sysfs.c+83 -511 reply
3/3tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operationsdrivers/char/tpm/tpm-chip.c+4 -52 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchStefan BergerJerry SnitselaarJames BottomleyAlexander SteffenJarkko Sakkinen
1/3
2/3R-b T-b R-b R-b T-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream

This backport is for v4.14 and v4.19 The backport requires non-racy behaviour from TPM 1.x sysfs code. Thus, the dependecies for that are included.

NOTE: 1/3 is only needed for v4.14.

v4:
* There was unnecessary assignment inside TPM_CHIP_FLAG_TPM2 branch (does not cause any run-time issue).
v3:
* Fixed the cover letter and the subject prefix. My deepest apologies for all the hassle :-(
v2:
* Something happened when merging 3/3 that write lock was taken twice. Fixed in this version. Did also sanity check test with TPM2:
echo devices > /sys/power/pm_test && echo mem > /sys/power/state

Jarkko Sakkinen (2):
tpm: migrate pubek_show to struct tpm_buf
tpm: use tpm_try_get_ops() in tpm-sysfs.c.

Vadim Sukhomlinov (1):
tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

 drivers/char/tpm/tpm-chip.c  |   9 +-
 drivers/char/tpm/tpm-sysfs.c | 201 +++++++++++++++++++++--------------
 drivers/char/tpm/tpm.h       |  13 ---
 3 files changed, 125 insertions(+), 98 deletions(-)
Signature · 1 line
2.20.1