Skip to content

remove 'typedef int bool'

Dharmik Thakkar dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyIn review
  2. v27 patches 4 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- Rebase on dpdk-next-net
- Fix build issue in net/ixgbe
---

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net/ixgbe: avoid multpile definitions of 'bool'drivers/net/ixgbe/base/ixgbe_osdep.h drivers/net/ixgbe/ixgbe_ethdev.c+7 -70 replies
2/7net/cxgbe: remove 'typedef int bool'drivers/net/cxgbe/cxgbe_compat.h drivers/net/cxgbe/cxgbe_main.c+8 -90 replies
3/7net/vmxnet3: remove 'typedef int bool'drivers/net/vmxnet3/base/vmxnet3_defs.h drivers/net/vmxnet3/base/vmxnet3_osdep.h+5 -50 replies
4/7net/bnx2x: remove 'typedef int bool'drivers/net/bnx2x/bnx2x_ethdev.h drivers/net/bnx2x/ecore_sp.c+24 -260 replies
5/7net/e1000: remove 'typedef int bool'drivers/net/e1000/base/e1000_osdep.h+1 -40 replies
6/7net/fm10k: remove 'typedef int bool'drivers/net/fm10k/base/fm10k_osdep.h drivers/net/fm10k/fm10k_ethdev.c+4 -100 replies
7/7net/qede: remove 'typedef int bool'drivers/net/qede/base/bcm_osal.h drivers/net/qede/base/ecore_vf.c drivers/net/qede/qede_ethdev.c+3 -60 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhil YangRuifeng WangYong WangGavin HuXiao WangFerruh Yigit
SeriesR-b
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b A-b
4/7R-b R-b
5/7R-b
6/7R-b R-b A-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/7] remove 'typedef int bool'

Replace 'typedef int bool' with 'stdbool.h' Thus, avoid future compilation problems when 'stdbool.h' gets included in these files.

---
v3:
- Rebase on dpdk-next-net
- Fix build issue in net/ixgbe
---
v2:
- Remove 'typedef int bool' from other drivers
---

Dharmik Thakkar (7):
net/ixgbe: avoid multpile definitions of 'bool'
net/cxgbe: remove 'typedef int bool'
net/vmxnet3: remove 'typedef int bool'
net/bnx2x: remove 'typedef int bool'
net/e1000: remove 'typedef int bool'
net/fm10k: remove 'typedef int bool'
net/qede: remove 'typedef int bool'

 drivers/net/bnx2x/bnx2x_ethdev.h         |  4 +--
 drivers/net/bnx2x/ecore_sp.c             | 46 ++++++++++++------------
 drivers/net/cxgbe/cxgbe_compat.h         |  4 +--
 drivers/net/cxgbe/cxgbe_main.c           | 13 +++----
 drivers/net/e1000/base/e1000_osdep.h     |  5 +--
 drivers/net/fm10k/base/fm10k_osdep.h     |  8 +----
 drivers/net/fm10k/fm10k_ethdev.c         |  6 ++--
 drivers/net/ixgbe/base/ixgbe_osdep.h     |  4 +--
 drivers/net/ixgbe/ixgbe_ethdev.c         | 10 +++---
 drivers/net/qede/base/bcm_osal.h         |  5 +--
 drivers/net/qede/base/ecore_vf.c         |  2 +-
 drivers/net/qede/qede_ethdev.c           |  2 +-
 drivers/net/vmxnet3/base/vmxnet3_defs.h  |  6 ++--
 drivers/net/vmxnet3/base/vmxnet3_osdep.h |  4 +--
 14 files changed, 52 insertions(+), 67 deletions(-)
Signature · 1 line
2.17.1