Skip to content

fw_cfg: Run tests on big-endian

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 13 repliesIn review
  2. v17 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tests/libqos/fw_cfg: Document io_fw_cfg_init to drop io_fw_cfg_uninittests/libqos/fw_cfg.c tests/libqos/fw_cfg.h+9 -71 reply
2/7tests/libqos/fw_cfg: Document mm_fw_cfg_init to drop mm_fw_cfg_uninittests/libqos/fw_cfg.c tests/libqos/fw_cfg.h+9 -61 reply
3/7tests/libqos/fw_cfg: Document pc_fw_cfg_init to drop pc_fw_cfg_uninittests/fw_cfg-test.c tests/libqos/fw_cfg.h tests/libqos/malloc-pc.c+21 -171 reply
4/7tests/fw_cfg: Let the tests use a contexttests/fw_cfg-test.c+54 -331 reply
5/7tests/libqos/fw_cfg: Pass QTestState as argumenttests/boot-order-test.c tests/fw_cfg-test.c tests/libqos/fw_cfg.c +2 more+78 -791 reply
6/7tests/fw_cfg: Declare one QFWCFG for all teststests/fw_cfg-test.c+32 -481 reply
7/7tests/fw_cfg: Run the tests on big-endian targetstests/Makefile.include tests/fw_cfg-test.c+29 -67 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchLaszlo ErsekLi Qiang
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b R-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] fw_cfg: Run tests on big-endian

This series allow fw_cfg tests to run on big-endian targets.

since v1 [1]:
- addressed Laszlo/Laurent/Thomas comments
- added Laszlo R-b tags

This should help us to notice regression such this one introduced in QEMU v4.0.0:

commit ee5d0f89de3e53cdb0dcf51acc1502b310ed3bd2
Date: Tue Nov 20 21:10:25 2018 -0800

fw_cfg: Fix -boot reboot-timeout error checking

Later fixed in QEMU v4.1.0:

commit 04da973501b591525ce68c2925c61c8886badd4d
Date: Wed Apr 24 07:06:41 2019 -0700

hw/nvram/fw_cfg: Store 'reboot-timeout' as little endian

And older one that required manual testing [2], such:

commit 36b62ae6a58f9a588fd33be9386e18a2b90103f5

fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00926.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2014-12/msg03762.html

Philippe Mathieu-Daudé (7):
tests/libqos/fw_cfg: Document io_fw_cfg_init to drop io_fw_cfg_uninit tests/libqos/fw_cfg: Document mm_fw_cfg_init to drop mm_fw_cfg_uninit tests/libqos/fw_cfg: Document pc_fw_cfg_init to drop pc_fw_cfg_uninit tests/fw_cfg: Let the tests use a context tests/libqos/fw_cfg: Pass QTestState as argument tests/fw_cfg: Declare one QFWCFG for all tests tests/fw_cfg: Run the tests on big-endian targets

 tests/Makefile.include   |   2 +
 tests/boot-order-test.c  |  12 +--
 tests/fw_cfg-test.c      | 189 ++++++++++++++++++++++-----------------
 tests/libqos/fw_cfg.c    |  71 +++++++--------
 tests/libqos/fw_cfg.h    |  56 +++++++-----
 tests/libqos/malloc-pc.c |   6 +-
 6 files changed, 186 insertions(+), 150 deletions(-)
Signature · 1 line
2.21.0