Skip to content

btrfs: tree-checker: False alerts fixes for log trees

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: tree-checker: Fix false alerts on log treesfs/btrfs/tree-checker.c+4 -25 replies
2/3btrfs: tree-checker: Refactor prev_key check for ino into a functionfs/btrfs/tree-checker.c+72 -410 replies
3/3btrfs: Enhance the error outputting for write time tree checkerfs/btrfs/disk-io.c+2 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchFilipe Manana
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: tree-checker: False alerts fixes for log trees

There is a false alerts of tree-checker when running fstests/btrfs/063 in a loop.

The bug is caused by commit 59b0d030fb30 ("btrfs: tree-checker: Try to detect missing INODE_ITEM").
For the full error analyse, please check the first patch.

The first patch will give it a quick fix, so that it can be addressed in v5.4 release cycle.

The 2nd patch is a more proper patch, with refactor to reduce duplicated code and add the check to INODE_REF item.
But it's pretty large (+72, -41), not sure if it's suitbale for late -rc.

Also current write-time tree checker error message is too silent, can't be caught by fstests nor a quick glance of dmesg. And it doesn't contain enough info to debug.

So to enhance the error message, and make it more noisy, the 3rd patch will enhance the error message.

Qu Wenruo (3):
btrfs: tree-checker: Fix false alerts on log trees
btrfs: tree-checker: Refactor prev_key check for ino into a function
btrfs: Enhance the error outputting for write time tree checker

 fs/btrfs/disk-io.c      |   2 +
 fs/btrfs/tree-checker.c | 111 ++++++++++++++++++++++++++--------------
 2 files changed, 74 insertions(+), 39 deletions(-)
Signature · 1 line
2.23.0