Skip to content

Enable bigjoiner support, second approach.

Maarten Lankhorst intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24HAX to make DSC work on the icelake test systemdrivers/gpu/drm/drm_dp_helper.c include/drm/drm_dp_helper.h+3 -20 replies
2/24drm/i915: Fix for_each_intel_plane_mask definitiondrivers/gpu/drm/i915/display/intel_display.h+1 -12 replies
3/24drm/i915: Introduce and use intel_atomic_crtc_state_for_each_plane_state.drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/intel_pm.c+33 -352 replies
4/24drm/i915: Remove cursor use of properties for coordinatesdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/intel_pm.c+53 -624 replies
5/24drm/i915: Use intel_plane_state in prepare and cleanup plane_fbdrivers/gpu/drm/i915/display/intel_display.c+16 -122 replies
6/24drm/i915: Remove begin/finish_crtc_commit, v4.drivers/gpu/drm/i915/display/intel_display.c+99 -1111 reply
7/24drm/i915: Introduce intel_atomic_get_plane_state_after_check()drivers/gpu/drm/i915/display/intel_atomic.c drivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_cdclk.c +3 more+66 -364 replies
8/24drm/i915: Prepare to split crtc state in uapi and hw statedrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_atomic.c drivers/gpu/drm/i915/display/intel_atomic_plane.c +28 more+700 -6654 replies
9/24drm/i915: Handle a few more cases for crtc hw/uapi splitdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dp_mst.c drivers/gpu/drm/i915/display/intel_psr.c+10 -103 replies
10/24drm/i915: Complete crtc hw/uapi split, v2.drivers/gpu/drm/i915/display/intel_atomic.c drivers/gpu/drm/i915/display/intel_atomic.h drivers/gpu/drm/i915/display/intel_display.c +1 more+89 -90 replies
11/24drm/i915: Preparation for plane splitdrivers/gpu/drm/i915/display/intel_atomic.c drivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_display.c +5 more+379 -3730 replies
12/24drm/i915: Split plane hw and uapi statedrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_display.c +1 more+57 -56 replies
13/24drm/i915: Stop using drm_atomic_helper_check_planes()drivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_display.c+50 -190 replies
14/24drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v2.drivers/gpu/drm/i915/display/intel_dp.c+72 -201 reply
15/24drm/i915: Try to make bigjoiner work in atomic check, v2.drivers/gpu/drm/i915/display/intel_atomic.c drivers/gpu/drm/i915/display/intel_atomic.h drivers/gpu/drm/i915/display/intel_display.c +2 more+234 -382 replies
16/24drm/i915: Enable big joiner support in enable and disable sequences.drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h +3 more+418 -1980 replies
17/24drm/i915: Make hardware readout work on i915.drivers/gpu/drm/i915/display/intel_display.c+62 -30 replies
18/24drm/i915: Remove special case slave handling during hw programmingdrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_display.c +2 more+39 -730 replies
19/24drm/i915: Link planes in a bigjoiner configuration, v2.drivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_display.c +2 more+211 -240 replies
20/24drm/i915: Add bigjoiner aware plane clipping checksdrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_display.c +1 more+80 -240 replies
21/24drm/i915: Ensure color blobs are copied to slave before planes are checkeddrivers/gpu/drm/i915/display/intel_display.c+10 -00 replies
22/24drm/i915: Add intel_update_bigjoiner handling.drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/display/intel_sprite.h+123 -200 replies
23/24drm/i915: Add debugfs dumping for bigjoiner, v2.drivers/gpu/drm/i915/i915_debugfs.c+26 -230 replies
24/24semi-hax: drm/i915: Always verify ddb allocationdrivers/gpu/drm/i915/display/intel_display.c+3 -21 reply

Reviews trailers per patch

8 of 24 patches have a Reviewed-by or Acked-by.

PatchMatt RoperStanislav LisovskiyVille Syrjälä
1/24
2/24R-b R-b
3/24R-b R-b
4/24R-b
5/24R-b R-b
6/24R-b
7/24
8/24R-b
9/24R-b
10/24
11/24
12/24
13/24R-b
14/24
15/24
16/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/24] Enable bigjoiner support, second approach.

The first approach centered on ensuring that bigjoiner had a separate master_plane_state and slave_plane_state, this complicated the code too much.

The new approach performs the same uapi and hw split as I did for crtc_state, and allows bigjoiner to work with very small modifications in comparison to the first approach.

The bigjoiner implementation itself is now only:

 14 files changed, 1269 insertions(+), 417 deletions(-)

Compared to the massive changes before, I like it. :)

Maarten Lankhorst (23):
HAX to make DSC work on the icelake test system
drm/i915: Fix for_each_intel_plane_mask definition drm/i915: Introduce and use
intel_atomic_crtc_state_for_each_plane_state.
drm/i915: Remove cursor use of properties for coordinates drm/i915: Use intel_plane_state in prepare and cleanup plane_fb drm/i915: Remove begin/finish_crtc_commit, v4.
drm/i915: Introduce intel_atomic_get_plane_state_after_check() drm/i915: Prepare to split crtc state in uapi and hw state drm/i915: Handle a few more cases for crtc hw/uapi split drm/i915: Complete crtc hw/uapi split, v2.
drm/i915: Preparation for plane split
drm/i915: Split plane hw and uapi state
drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v2. drm/i915: Try to make bigjoiner work in atomic check, v2. drm/i915: Enable big joiner support in enable and disable sequences. drm/i915: Make hardware readout work on i915.
drm/i915: Remove special case slave handling during hw programming drm/i915: Link planes in a bigjoiner configuration, v2. drm/i915: Add bigjoiner aware plane clipping checks drm/i915: Ensure color blobs are copied to slave before planes are
checked
drm/i915: Add intel_update_bigjoiner handling.
drm/i915: Add debugfs dumping for bigjoiner, v2.
semi-hax: drm/i915: Always verify ddb allocation

Ville Syrjälä (1):
drm/i915: Stop using drm_atomic_helper_check_planes()

 drivers/gpu/drm/drm_dp_helper.c               |    4 +-
 drivers/gpu/drm/i915/display/icl_dsi.c        |   18 +-
 drivers/gpu/drm/i915/display/intel_atomic.c   |  108 +-
 drivers/gpu/drm/i915/display/intel_atomic.h   |    3 +
 .../gpu/drm/i915/display/intel_atomic_plane.c |  249 +-
 .../gpu/drm/i915/display/intel_atomic_plane.h |   12 +-
 drivers/gpu/drm/i915/display/intel_audio.c    |   12 +-
 drivers/gpu/drm/i915/display/intel_bw.c       |    4 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |   31 +-
 drivers/gpu/drm/i915/display/intel_color.c    |  187 +-
 drivers/gpu/drm/i915/display/intel_crt.c      |   24 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |   89 +-
 drivers/gpu/drm/i915/display/intel_display.c  | 2208 +++++++++++------
 drivers/gpu/drm/i915/display/intel_display.h  |   20 +-
 .../drm/i915/display/intel_display_types.h    |  100 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  173 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |    8 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |   14 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   20 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      |   14 +-
 drivers/gpu/drm/i915/display/intel_fbc.c      |   22 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   64 +-
 drivers/gpu/drm/i915/display/intel_lspcon.c   |    4 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |   12 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |    4 +-
 drivers/gpu/drm/i915/display/intel_panel.c    |   14 +-
 drivers/gpu/drm/i915/display/intel_pipe_crc.c |    6 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   14 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   22 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |  295 ++-
 drivers/gpu/drm/i915/display/intel_sprite.h   |    3 +-
 drivers/gpu/drm/i915/display/intel_tv.c       |    8 +-
 drivers/gpu/drm/i915/display/intel_vdsc.c     |  134 +-
 drivers/gpu/drm/i915/display/intel_vdsc.h     |    2 +
 drivers/gpu/drm/i915/display/vlv_dsi.c        |   20 +-
 drivers/gpu/drm/i915/i915_debugfs.c           |   63 +-
 drivers/gpu/drm/i915/intel_pm.c               |  381 ++-
 include/drm/drm_dp_helper.h                   |    1 +
 38 files changed, 2718 insertions(+), 1649 deletions(-)
Signature · 6 lines
2.23.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx