Skip to content

xfs: fix sf to block inode fork logging

Brian Foster linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v11 patch 2 repliesSuperseded

Changes in v2 from the cover letter

- Also fix up attr fork conversion.
- Add patches 2 and 3 for follow up cleanups.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: log the inode on directory sf to block format changefs/xfs/libxfs/xfs_attr_leaf.c fs/xfs/libxfs/xfs_dir2_block.c+2 -02 replies
2/3xfs: remove broken error handling on failed attr sf to leaf changefs/xfs/libxfs/xfs_attr_leaf.c+2 -172 replies
3/3xfs: move local to extent inode logging into bmap helperfs/xfs/libxfs/xfs_attr_leaf.c fs/xfs/libxfs/xfs_bmap.c fs/xfs/libxfs/xfs_bmap.h +1 more+8 -72 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDarrick J. Wong
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] xfs: fix sf to block inode fork logging

Hi all,

Here's v2 of the directory inode shortform to block logging fixup. This also addresses the similar attr fork conversion function. I put the other cleanups into separate patches because it wasn't totally clear to me if we wanted to add the log call to the conversion function given the other callers log the inode outside of that function. IOW, we can either keep or drop patch 3. I have no strong preference either way.

Brian

v2:
- Also fix up attr fork conversion.
- Add patches 2 and 3 for follow up cleanups.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

Brian Foster (3):
xfs: log the inode on directory sf to block format change
xfs: remove broken error handling on failed attr sf to leaf change
xfs: move local to extent inode logging into bmap helper

 fs/xfs/libxfs/xfs_attr_leaf.c  | 21 +++------------------
 fs/xfs/libxfs/xfs_bmap.c       |  6 ++++--
 fs/xfs/libxfs/xfs_bmap.h       |  3 ++-
 fs/xfs/libxfs/xfs_dir2_block.c |  2 +-
 4 files changed, 10 insertions(+), 22 deletions(-)
Signature · 1 line
2.20.1