struct argv overhual - Oct 2019 edition
Get series with b4
b4 am [email protected]...Versions newest first
- v1 Latest4 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | re-implement argv_printf_*()src/ src/ src/ +2 more | +206 | 2 replies | |
| 2/4 | argv: do fewer memory re-allocationssrc/ src/ src/ +12 more | +124 | 0 replies | |
| 3/4 | Add gc_arena to struct argv to save allocationssrc/ src/ tests/ | +45 | 0 replies | |
| 4/4 | Documented all the argv related code with minor refactoringsrc/ | +211 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Openvpn-devel] [PATCH 0/4] struct argv overhual - Oct 2019 edition
Hi,
I've rebased the last attempt of the struct argv overual patches [1] to the lastest public git master [2].
This rebase just needed a few minor changes to account for changes with tls-crypt-v2 and sitnl patches now being included. I've also applied Arne's review comments [3].
To simplify the review, I've also pushed these changes to my gitlab account:
https://gitlab.com/dazo/openvpn.git
Look at the dev/struct-argv-overhaul-2019.10 branch for the proper commits.
[1] <https://patchwork.openvpn.net/project/openvpn2/list/?series=386>
[2] git master commit ef2c7b2fa4fd9fae934e608e37dc8d98edbace5f
[3] Message-ID: <[email protected]...>
<https://www.mail-archive.com/[email protected]/msg17957.html>
--
kind regards,
David Sommerseth
OpenVPN Inc
----------------------------------------------------------------
David Sommerseth (1):
Documented all the argv related code with minor refactoring
Heiko Hund (3):
re-implement argv_printf_*()
argv: do fewer memory re-allocations
Add gc_arena to struct argv to save allocations
src/openvpn/argv.c | 525 +++++++++++++++++---------- src/openvpn/argv.h | 7 +- src/openvpn/console_systemd.c | 2 +- src/openvpn/init.c | 15 +- src/openvpn/lladdr.c | 2 +- src/openvpn/multi.c | 10 +- src/openvpn/networking_iproute2.c | 23 +- src/openvpn/options.c | 2 +- src/openvpn/plugin.c | 2 +- src/openvpn/route.c | 16 +- src/openvpn/socket.c | 4 +- src/openvpn/ssl_verify.c | 6 +- src/openvpn/tls_crypt.c | 2 +- src/openvpn/tun.c | 62 ++-- tests/unit_tests/openvpn/test_argv.c | 118 +++++- 15 files changed, 509 insertions(+), 287 deletions(-)
Signature · 1 line
2.17.1