Skip to content

mlxsw: Query number of modules from firmware

Ido Schimmel netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mlxsw: reg: Extend MGPIR register with new field exposing the number of QSFP modulesdrivers/net/ethernet/mellanox/mlxsw/core_hwmon.c drivers/net/ethernet/mellanox/mlxsw/core_thermal.c drivers/net/ethernet/mellanox/mlxsw/reg.h+12 -30 replies
2/5mlxsw: hwmon: Provide optimization for QSFP modules number detectiondrivers/net/ethernet/mellanox/mlxsw/core_hwmon.c+29 -350 replies
3/5mlxsw: thermal: Provide optimization for QSFP modules number detectiondrivers/net/ethernet/mellanox/mlxsw/core_thermal.c+16 -210 replies
4/5mlxsw: core: Push minor/subminor fw version check into helperdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c+16 -30 replies
5/5mlxsw: minimal: Add validation for FW versiondrivers/net/ethernet/mellanox/mlxsw/minimal.c+30 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJiri Pirko
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/5] mlxsw: Query number of modules from firmware

From: Ido Schimmel <[email protected]>

Vadim says:

The patchset adds support for a new field "num_of_modules" of Management General Peripheral Information Register (MGPIR), providing the maximum number of QSFP modules, which can be supported by the system.

It allows to obtain the number of QSFP modules directly from this field, as a static data, instead of old method of getting this info through "network port to QSFP module" mapping. With the old method, in case of port dynamic re-configuration some modules can logically "disappear" as a result of port split operations, which can cause some modules to appear missing.

Such scenario can happen on a system equipped with a BMC card, while PCI chip driver at host CPU side can perform some ports "split" or "unsplit" operations, while BMC side I2C chip driver reads the "port-to-module" mapping.

Add common API for FW "minor" and "subminor" versions validation and share it between PCI and I2C based drivers.

Add FW version validation for "minimal" driver, because use of new field "num_of_modules" in MGPIR register is not backward compatible.

Vadim Pasternak (5):
mlxsw: reg: Extend MGPIR register with new field exposing the number
of QSFP modules
mlxsw: hwmon: Provide optimization for QSFP modules number detection
mlxsw: thermal: Provide optimization for QSFP modules number detection
mlxsw: core: Push minor/subminor fw version check into helper
mlxsw: minimal: Add validation for FW version

 drivers/net/ethernet/mellanox/mlxsw/core.c    | 10 +++
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  5 ++
 .../net/ethernet/mellanox/mlxsw/core_hwmon.c  | 66 +++++++++----------
 .../ethernet/mellanox/mlxsw/core_thermal.c    | 40 +++++------
 drivers/net/ethernet/mellanox/mlxsw/minimal.c | 30 +++++++++
 drivers/net/ethernet/mellanox/mlxsw/reg.h     | 10 ++-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  4 +-
 7 files changed, 103 insertions(+), 62 deletions(-)
Signature · 1 line
2.21.0