Skip to content

x86/vdso: sgx: Major vDSO cleanup

Sean Christopherson linux-sgx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16x86/vdso: sgx: Drop the pseudocode "documentation"arch/x86/entry/vdso/vsgx_enter_enclave.S+1 -240 replies
2/16x86/vdso: sgx: Do not use exception info to pass success/failurearch/x86/entry/vdso/vsgx_enter_enclave.S+15 -180 replies
3/16x86/vdso: sgx: Rename the enclave exit handler typedefarch/x86/entry/vdso/vsgx_enter_enclave.S+10 -100 replies
4/16x86/vdso: sgx: Move enclave exit handler declaration to UAPI headerarch/x86/entry/vdso/vsgx_enter_enclave.S arch/x86/include/uapi/asm/sgx.h+18 -30 replies
5/16x86/vdso: sgx: Add comment regarding kernel-doc shenanigansarch/x86/entry/vdso/vsgx_enter_enclave.S+2 -10 replies
6/16x86/vdso: sgx: Rewrite __vdso_sgx_enter_enclave() function commentarch/x86/entry/vdso/vsgx_enter_enclave.S+46 -280 replies
7/16selftests/x86: Fix linker warning in SGX selftesttools/testing/selftests/x86/sgx/Makefile+1 -10 replies
8/16selftests/x86/sgx: Use getauxval() to retrieve the vDSO base addresstools/testing/selftests/x86/sgx/main.c+5 -160 replies
9/16selftests/x86/sgx: Add helper function and macros to assert resultstools/testing/selftests/x86/sgx/main.c+45 -70 replies
10/16selftests/x86/sgx: Handle setup failures via test assertionstools/testing/selftests/x86/sgx/main.c+59 -1119 replies
11/16selftests/x86/sgx: Sanitize the types for sgx_call()'s input paramstools/testing/selftests/x86/sgx/main.c+4 -30 replies
12/16selftests/x86/sgx: Move existing sub-test to a separate helpertools/testing/selftests/x86/sgx/main.c+17 -80 replies
13/16selftests/x86/sgx: Add a test of the vDSO exception reporting mechanismtools/testing/selftests/x86/sgx/defines.h tools/testing/selftests/x86/sgx/main.c+10 -00 replies
14/16selftests/x86/sgx: Add test of vDSO with basic exit handlertools/testing/selftests/x86/sgx/main.c+26 -00 replies
15/16selftests/x86/sgx: Add sub-test for exception behavior with exit handlertools/testing/selftests/x86/sgx/defines.h tools/testing/selftests/x86/sgx/main.c+87 -20 replies
16/16x86/vdso: sgx: Rework __vdso_sgx_enter_enclave() to prefer "no callback"arch/x86/entry/vdso/vsgx_enter_enclave.S+71 -497 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH for_v23 00/16] x86/vdso: sgx: Major vDSO cleanup

The main purpose of this series is to implement feedback from the original RFC to expand the vDSO[*] that went unaddressed before the expanded function was rushed into v21.

The other half of the series is to overhaul the selftest to actually test the exit handler variation of the vDSO, with a bunch of prework to add an assertion framework to standardize the various assertions in the test and improve the readability of the code.

The basic ideas for the exit handler subtests are from Cedric's original RFC, but rewritten from scratch to take advantage of the new assertion framework. I haven't yet implemented single-step subtest, ideally that too will get done before v23.

[*] https://lkml.kernel.org/r/[email protected]

Sean Christopherson (16):
x86/vdso: sgx: Drop the pseudocode "documentation" x86/vdso: sgx: Do not use exception info to pass success/failure x86/vdso: sgx: Rename the enclave exit handler typedef x86/vdso: sgx: Move enclave exit handler declaration to UAPI header x86/vdso: sgx: Add comment regarding kernel-doc shenanigans x86/vdso: sgx: Rewrite __vdso_sgx_enter_enclave() function comment selftests/x86: Fix linker warning in SGX selftest selftests/x86/sgx: Use getauxval() to retrieve the vDSO base address selftests/x86/sgx: Add helper function and macros to assert results selftests/x86/sgx: Handle setup failures via test assertions selftests/x86/sgx: Sanitize the types for sgx_call()'s input params selftests/x86/sgx: Move existing sub-test to a separate helper selftests/x86/sgx: Add a test of the vDSO exception reporting
mechanism
selftests/x86/sgx: Add test of vDSO with basic exit handler selftests/x86/sgx: Add sub-test for exception behavior with exit
handler
x86/vdso: sgx: Rework __vdso_sgx_enter_enclave() to prefer "no
callback"

 arch/x86/entry/vdso/vsgx_enter_enclave.S  | 228 +++++++------
 arch/x86/include/uapi/asm/sgx.h           |  18 +
 tools/testing/selftests/x86/sgx/Makefile  |   2 +-
 tools/testing/selftests/x86/sgx/defines.h |   6 +
 tools/testing/selftests/x86/sgx/main.c    | 384 ++++++++++++++--------
 5 files changed, 387 insertions(+), 251 deletions(-)
Signature · 1 line
2.22.0