Skip to content

fix distributor unit test

Ruifeng Wang dpdk-dev 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 7 repliesApplied
  2. v22 patches 2 repliesSuperseded
  3. v11 patch 7 repliesSuperseded

Changes in v3 from the cover letter

Added comments for using of C11 acquire/release semantics. (Honnappa)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2lib/distributor: fix deadlock issue for aarch64lib/librte_distributor/meson.build lib/librte_distributor/rte_distributor.c lib/librte_distributor/rte_distributor_v20.c+97 -351 reply
2/2test/distributor: fix false unit test failureapp/test/test_distributor.c+4 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGavin HuDavid Hunt
SeriesA-b
1/2R-b A-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/2] fix distributor unit test

Bug 342 reported distributor_autotest execution suspension on aarch64 platform.
Issue was due to lack of synchronization among threads. Distributor thread and worker thread may get deadlocked.
Fixed synchronization issue by adding barriers.

Another issue identified was in test case. Non-atomic operation on stat value could cause value reset not been observed by worker thread and mess counters. The issue was fixed by using atomic operations.

---
v3:
Added comments for using of C11 acquire/release semantics. (Honnappa)

v2:
Fixed intermittent packet count incorrect failure. (Aaron, David) Fixed Clang build on 32bit systems.
Additional patch to fix non-atomic operation in unit test.

Ruifeng Wang (2):
lib/distributor: fix deadlock issue for aarch64
test/distributor: fix false unit test failure

 app/test/test_distributor.c                  |  6 +-
 lib/librte_distributor/meson.build           |  5 ++
 lib/librte_distributor/rte_distributor.c     | 68 ++++++++++++++------
 lib/librte_distributor/rte_distributor_v20.c | 59 ++++++++++++-----
 4 files changed, 101 insertions(+), 37 deletions(-)
Signature · 1 line
2.17.1