Skip to content

hw/i386: pass "MachineState.smp.max_cpus" to OVMF

Laszlo Ersek qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fw_cfg: bump file slots to 40hw/core/machine.c hw/nvram/fw_cfg.c+3 -10 replies
2/4target/i386: remove useless enable_compat_apic_id_mode() prototypetarget/i386/cpu.h+0 -22 replies
3/4hw/i386: add facility to expose CPU topology over fw-cfghw/i386/fw_cfg.c hw/i386/fw_cfg.h hw/i386/pc.c+55 -516 replies
4/4hw/i386/pc: expose CPU topology over fw-cfghw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +1 more+9 -10 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/4
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] hw/i386: pass "MachineState.smp.max_cpus" to OVMF

https://bugzilla.tianocore.org/show_bug.cgi?id=1515

For enabling VCPU hotplug with OVMF, OVMF needs to know the value of "max_cpus". This quantity is not passed to the firmware currently -- SeaBIOS receives the (exclusive) maximum APICID, which is not useful to OVMF --, so introduce a new fw_cfg file for this purpose.

Note: when OVMF is built with -D SMM_REQUIRE, this patch series is just a small building block, towards the full VCPU hotplug feature. However, when OVMF is built without -D SMM_REQUIRE, this series (together with the counterpart patch set for OVMF) completes the VCPU hotplug feature:
it allows S3 resume to work with VCPUs hot-plugged previously (at OS runtime, of course).

Cc "Michael S. Tsirkin" <[email protected]>
Cc Eduardo Habkost <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Igor Mammedov <[email protected]>
Cc Marcel Apfelbaum <[email protected]>
Cc Paolo Bonzini <[email protected]>
Cc Philippe Mathieu-Daudé <[email protected]>
Cc Richard Henderson <[email protected]>

Thanks
Laszlo

Laszlo Ersek (4):
fw_cfg: bump file slots to 40
target/i386: remove useless enable_compat_apic_id_mode() prototype hw/i386: add facility to expose CPU topology over fw-cfg hw/i386/pc: expose CPU topology over fw-cfg

 hw/core/machine.c    |  2 ++
 hw/i386/fw_cfg.c     | 26 ++++++++++++++++++++++++--
 hw/i386/fw_cfg.h     | 30 +++++++++++++++++++++++++++++-
 hw/i386/pc.c         |  5 +++--
 hw/i386/pc_piix.c    |  2 ++
 hw/i386/pc_q35.c     |  2 ++
 hw/nvram/fw_cfg.c    |  2 +-
 include/hw/i386/pc.h |  3 +++
 target/i386/cpu.h    |  2 --
 9 files changed, 66 insertions(+), 8 deletions(-)
Signature · 1 line
2.19.1.3.g30247aa5d201