Skip to content

USB: iowarrior: disconnect fixes and locking cleanups

Johan Hovold linux-usb lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6USB: iowarrior: fix use-after-free on disconnectdrivers/usb/misc/iowarrior.c+3 -40 replies
2/6USB: iowarrior: fix use-after-free on releasedrivers/usb/misc/iowarrior.c+2 -10 replies
3/6USB: iowarrior: fix use-after-free after driver unbinddrivers/usb/misc/iowarrior.c+6 -00 replies
4/6USB: iowarrior: drop redundant disconnect mutexdrivers/usb/misc/iowarrior.c+2 -150 replies
5/6USB: iowarrior: drop redundant iowarrior mutexdrivers/usb/misc/iowarrior.c+1 -120 replies
6/6USB: iowarrior: use pr_err()drivers/usb/misc/iowarrior.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] USB: iowarrior: disconnect fixes and locking cleanups

This series fixes a use-after-free bug introduced by a recent disconnect-deadlock fix that was reported by syzbot. Turns out there was already a related bug in the driver, and the first patch addresses both issues.

While looking at the code I found two more use-after-free bugs, which the next two patches fix.

The next two clean up the driver by dropping two redundant locks.

Tested using a mockup device.

Johan

Johan Hovold (6):
USB: iowarrior: fix use-after-free on disconnect
USB: iowarrior: fix use-after-free on release
USB: iowarrior: fix use-after-free after driver unbind
USB: iowarrior: drop redundant disconnect mutex
USB: iowarrior: drop redundant iowarrior mutex
USB: iowarrior: use pr_err()

 drivers/usb/misc/iowarrior.c | 48 +++++++++++-------------------------
 1 file changed, 15 insertions(+), 33 deletions(-)
Signature · 1 line
2.23.0