PCI: pciehp: Do not turn off slot if presence comes up after link
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 17 repliesIn review
- v33 patches 7 repliesSuperseded
- v23 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
- remove "!!" boolean conversion in an "if" condition for readability
- add explanation comment in dmi table
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | PCI: pciehp: Add support for disabling in-band presencedrivers/ drivers/ include/ | +11 | 5 replies | |
| 2/3 | PCI: pciehp: Wait for PDS if in-band presence is disableddrivers/ | +19 | 1 reply | |
| 3/3 | PCI: pciehp: Add dmi table for in-band presence disableddrivers/ | +22 | 3 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andy Shevchenko | Mika Westerberg | Lukas Wunner |
|---|---|---|---|
| Series | R-b | R-b | |
| 1/3 | R-b | ||
| 2/3 | R-b | ||
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/3] PCI: pciehp: Do not turn off slot if presence comes up after link
In older PCIe specs, PDS (presence detect) would come up when the "in-band" presence detect pin connected, and would be up before DLLLA (link active).
In PCIe 4.0 (as an ECN) and in PCIe 5.0, there is a new bit to show if in-band presence detection can be disabled for the slot, and another bit that disables it--and a recommendation that it should be disabled if it can be. In addition, certain OEMs disable in-band presence detection without implementing these bits.
This means it is possible to get a "card present" interrupt after the link is up and the driver is loaded. This causes an erroneous removal of the device driver, followed by an immediate re-probing.
This patch set defines these new bits, uses them to disable in-band presence detection if it can be, waits for PDS to go up if in-band presence detection is disabled, and adds a DMI table that will let us know if we should assume in-band presence is disabled on a system.
The first two patches in this set come from a patch set that was submitted but not accepted many months ago by Alexandru Gagniuc [1]. The first is unmodified, the second has the commit message and timeout modified.
[1] https://patchwork.kernel.org/cover/10909167/
[v3,0/4] PCI: pciehp: Do not turn off slot if presence comes up after link
v2:
- modify loop in pcie_wait_for_presence to do..while
v3:
- remove unused variable declaration
- modify text of warning message
v4:
- remove "!!" boolean conversion in an "if" condition for readability
- add explanation comment in dmi table
Alexandru Gagniuc (2):
PCI: pciehp: Add support for disabling in-band presence
PCI: pciehp: Wait for PDS if in-band presence is disabled
Stuart Hayes (1):
PCI: pciehp: Add dmi table for in-band presence disabled
drivers/pci/hotplug/pciehp.h | 1 + drivers/pci/hotplug/pciehp_hpc.c | 50 +++++++++++++++++++++++++++++++- include/uapi/linux/pci_regs.h | 2 ++ 3 files changed, 52 insertions(+), 1 deletion(-)
Signature · 1 line
2.18.1