Skip to content

Improve objdump parsing, fix LLVM objdump

Ian Rogers lkml 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5perf annotate: avoid reallocation in objdump parsingtools/perf/util/annotate.c+14 -121 reply
2/5perf annotate: use run-command.h to fork objdumptools/perf/util/annotate.c+36 -352 replies
3/5perf annotate: don't pipe objdump output through greptools/perf/util/annotate.c+8 -11 reply
4/5perf annotate: don't pipe objdump output through expandtools/perf/util/annotate.c+76 -191 reply
5/5perf annotate: fix objdump --no-show-raw-insn flagtools/perf/util/annotate.c+2 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Improve objdump parsing, fix LLVM objdump

The objdump command line is piped through grep and expand meaning failures don't surface. Refactor symbol__disassemble so that it manages the memory for the read line, as well as trimming and expanding tabs. Correct the objdump flag '--no-show-raw' to be '--no-show-raw-insn' which binutils objdump permissively allows but fails with LLVM objdump.

Ian Rogers (5):
perf annotate: avoid reallocation in objdump parsing perf annotate: use run-command.h to fork objdump perf annotate: don't pipe objdump output through grep perf annotate: don't pipe objdump output through expand perf annotate: fix objdump --no-show-raw-insn flag

 tools/perf/util/annotate.c | 195 +++++++++++++++++++++++++------------
 1 file changed, 131 insertions(+), 64 deletions(-)
Signature · 1 line
2.23.0.581.g78d2f28ef7-goog