Fix KernelShark appearance on dark color schemes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | kernel-shark: Set text color to black in KsDualMarker's QLabelskernel-shark/ | +1 | 0 replies | |
| 2/4 | kernel-shark: Set text color to black in pointer position QLabelkernel-shark/ | +1 | 0 replies | |
| 3/4 | kernel-shark: Set text color to black in KsTraceGraph's axes labelskernel-shark/ | +3 | 0 replies | |
| 4/4 | kernel-shark: Change KsDualMarker's inactive button style to defaultkernel-shark/ | +1 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Steven Rostedt (VMware) |
|---|---|
| Series | A-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] Fix KernelShark appearance on dark color schemes
Currently a few widgets in Kernel Shark UI use custom stylesheets, unconditionally setting their background or text color (but not both!) to hard-coded values. This has a side effect of widget text being poorly readable on some color schemes (e.g. Breeze Dark, and dark schemes in general). This patch series tries to address this issue.
The first three patches are trivial: they ensure that whenever the background color of a widget is set to white via stylesheet, its text color is set to black.
The fourth one changes "inactive" marker selection button style to system default, making it look clickable on all color schemes.
Mikhail Rudenko (4):
kernel-shark: Set text color to black in KsDualMarker's QLabels
kernel-shark: Set text color to black in pointer position QLabel
kernel-shark: Set text color to black in KsTraceGraph's axes labels
kernel-shark: Change KsDualMarker's inactive button style to default
kernel-shark/src/KsDualMarker.cpp | 11 ++--------- kernel-shark/src/KsTraceGraph.cpp | 6 ++++-- 2 files changed, 6 insertions(+), 11 deletions(-)
--
2.23.0