Skip to content

Enable BACO for power savings

Alex Deucher amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/amdgpu: add asic callback for BACO supportdrivers/gpu/drm/amd/amdgpu/amdgpu.h+4 -00 replies
2/19drm/amdgpu: add supports_baco callback for soc15 asics.drivers/gpu/drm/amd/amdgpu/soc15.c+25 -12 replies
3/19drm/amdgpu: add supports_baco callback for SI asics.drivers/gpu/drm/amd/amdgpu/si.c+6 -00 replies
4/19drm/amdgpu: add supports_baco callback for CIK asics.drivers/gpu/drm/amd/amdgpu/cik.c+18 -00 replies
5/19drm/amdgpu: add supports_baco callback for VI asics.drivers/gpu/drm/amd/amdgpu/vi.c+22 -00 replies
6/19drm/amdgpu: add supports_baco callback for NV asics.drivers/gpu/drm/amd/amdgpu/nv.c+11 -00 replies
7/19drm/amdgpu: add a amdgpu_device_supports_baco helperdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c+16 -00 replies
8/19drm/amdgpu: rename amdgpu_device_is_px to amdgpu_device_supports_bocodrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 more+12 -121 reply
9/19drm/amdgpu: add additional boco checks to runtime suspend/resumedrivers/gpu/drm/amd/amdgpu/amdgpu_drv.c+26 -201 reply
10/19drm/amdgpu: split swSMU baco_reset into enter and exitdrivers/gpu/drm/amd/amdgpu/nv.c drivers/gpu/drm/amd/amdgpu/soc15.c drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h +1 more+32 -70 replies
11/19drm/amdgpu: add helpers for baco entry and exitdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c+63 -00 replies
12/19drm/amdgpu: add baco support to runtime suspend/resumedrivers/gpu/drm/amd/amdgpu/amdgpu_drv.c+6 -10 replies
13/19drm/amdgpu: start to disentangle boco from runtime pmdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c+17 -80 replies
14/19drm/amdgpu: disentangle runtime pm and vga_switcheroodrivers/gpu/drm/amd/amdgpu/amdgpu_device.c+14 -80 replies
15/19drm/amdgpu: enable runtime pm on BACO capable boards if runpm=1drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c+7 -40 replies
16/19drm/amdgpu/runpm: enable runpm on baco capable VI+ asicsdrivers/gpu/drm/amd/amdgpu/amdgpu_kms.c+6 -20 replies
17/19ALSA: hda/hdmi - fix vgaswitcheroo detection for AMDsound/pci/hda/hda_intel.c+39 -01 reply
18/19ALSA: hda/hdmi - enable runtime pm for newer AMD display audiosound/pci/hda/hda_intel.c+30 -52 replies
19/19ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by defaultsound/pci/hda/patch_hdmi.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] Enable BACO for power savings

This patch set enables BACO (Bus Active Chip Off) for power savings on VI+ asics. Similar to PowerXpress and Hybrid Graphics (PX/HG) laptops, we can disable GPUs at runtime when they are not in use is they support BACO. The runtime pm code in amdgpu was originally developed for PX/HG laptops, so it was pretty entangled with the vga_switcheroo and ACPI code. Since the GPU contains an audio codec for HDMI/DP, there is some interaction with the hda driver. I am by no means an expert on alsa, so any advice on those patches is much appreciated. I had to enable runtime pm on the hda device to allow the GPU to enter runtime pm because they are linked.

These patches depend on the clean patches and CI/VI BACO patches I sent out earlier today.

The full tree can be found here:
https://cgit.freedesktop.org/~agd5f/linux/log/?h=baco

TODO:
- Turn off runtime pm when KFD is active
- Make sure audio still works
- Make sure PX/HG still works

Alex Deucher (19):
drm/amdgpu: add asic callback for BACO support
drm/amdgpu: add supports_baco callback for soc15 asics. drm/amdgpu: add supports_baco callback for SI asics. drm/amdgpu: add supports_baco callback for CIK asics. drm/amdgpu: add supports_baco callback for VI asics. drm/amdgpu: add supports_baco callback for NV asics. drm/amdgpu: add a amdgpu_device_supports_baco helper drm/amdgpu: rename amdgpu_device_is_px to amdgpu_device_supports_boco drm/amdgpu: add additional boco checks to runtime suspend/resume drm/amdgpu: split swSMU baco_reset into enter and exit drm/amdgpu: add helpers for baco entry and exit drm/amdgpu: add baco support to runtime suspend/resume drm/amdgpu: start to disentangle boco from runtime pm drm/amdgpu: disentangle runtime pm and vga_switcheroo drm/amdgpu: enable runtime pm on BACO capable boards if runpm=1 drm/amdgpu/runpm: enable runpm on baco capable VI+ asics
ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD
ALSA: hda/hdmi - enable runtime pm for newer AMD display audio
ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by
default

 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |  12 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    | 106 ++++++++++++++++--
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |  64 ++++++-----
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       |  20 +++-
 drivers/gpu/drm/amd/amdgpu/cik.c              |  18 +++
 drivers/gpu/drm/amd/amdgpu/nv.c               |  18 ++-
 drivers/gpu/drm/amd/amdgpu/si.c               |   6 +
 drivers/gpu/drm/amd/amdgpu/soc15.c            |  37 +++++-
 drivers/gpu/drm/amd/amdgpu/vi.c               |  22 ++++
 .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h    |   9 +-
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c     |  12 +-
 sound/pci/hda/hda_intel.c                     |  74 +++++++++++-
 sound/pci/hda/patch_hdmi.c                    |   1 +
 13 files changed, 343 insertions(+), 56 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx