Skip to content

pci: pass along the return value of dma_memory_rw

Klaus Jensen qemu-devel qemu-trivial 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1pci: pass along the return value of dma_memory_rwinclude/hw/pci/pci.h+1 -25 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMichael S. Tsirkin
1/1R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] pci: pass along the return value of dma_memory_rw

Hi,

While working on fixing the emulated nvme device to pass more tests in the blktests suite, I discovered that the pci_dma_rw function ignores the return value of dma_memory_rw.

The nvme device needs to handle DMA errors gracefully in order to pass the block/011 test ("disable PCI device while doing I/O") in the blktests suite. This is only possible if the device knows if the DMA transfer was successful or not.

I can't see what the reason for ignoring the return value would be. But if there is a good reason, please enlighten me :)

Klaus Jensen (1):
pci: pass along the return value of dma_memory_rw

 include/hw/pci/pci.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.23.0