Skip to content

qapi: Add detection for the 'savevm' fix for blockdev

Markus Armbruster qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 1 replyIn review
  2. v44 patches 6 repliesSuperseded

Changes in v5 from the cover letter

* PATCH 2:
- qapi-code-gen.txt grammar updated
- Doc generation for boxed commands fixed
- Commit message tweaked
* PATCH 3:
- Command names in qapi-schema-test.json tweaked
- Trivial pycodestyle-3 fix
* PATCH 4: New
* PATCH 5: Whitespace tweaked

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tests/qapi-schema: Tidy up test output indentationtests/qapi-schema/doc-good.out tests/qapi-schema/event-case.out tests/qapi-schema/indented-expr.out +2 more+33 -330 replies
2/5qapi: Add feature flags to commandsdocs/devel/qapi-code-gen.txt qapi/introspect.json scripts/qapi/commands.py +5 more+62 -280 replies
3/5tests: qapi: Test 'features' of commandstests/qapi-schema/qapi-schema-test.json tests/qapi-schema/qapi-schema-test.out tests/qapi-schema/test-qapi.py +1 more+74 -40 replies
4/5tests/qapi-schema: Cover feature documentation commentstests/qapi-schema/doc-good.json tests/qapi-schema/doc-good.out tests/qapi-schema/doc-good.texi+42 -21 reply
5/5qapi: Allow introspecting fix for savevm's cooperation with blockdevqapi/misc.json+8 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMarkus ArmbrusterPeter KrempaEric Blake
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/5] qapi: Add detection for the 'savevm' fix for blockdev

Add 'features' field in the schema for commands and add a feature flag to advertise that the fix for savevm [1] is present.

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html

Based-on: <[email protected]>

v5:
* PATCH 2:
- qapi-code-gen.txt grammar updated
- Doc generation for boxed commands fixed
- Commit message tweaked
* PATCH 3:
- Command names in qapi-schema-test.json tweaked
- Trivial pycodestyle-3 fix
* PATCH 4: New
* PATCH 5: Whitespace tweaked

v4:
* PATCH 1: New
* PATCH 2: Factor out check_features()
* PATCH 3: Factor out _print_features(), drop duplicated test
* PATCH 4
- Shorten savevm-blockdev-monitor-nodes to just savevm-monitor-nodes
- Tweak commit message and documentation

Markus Armbruster (2):
tests/qapi-schema: Tidy up test output indentation tests/qapi-schema: Cover feature documentation comments

Peter Krempa (3):
qapi: Add feature flags to commands
tests: qapi: Test 'features' of commands
qapi: Allow introspecting fix for savevm's cooperation with blockdev

 docs/devel/qapi-code-gen.txt            | 10 ++--
 tests/qapi-schema/doc-good.texi         | 22 ++++++++
 qapi/introspect.json                    |  6 +-
 qapi/misc.json                          |  9 ++-
 tests/test-qmp-cmds.c                   | 24 ++++++++
 scripts/qapi/commands.py                |  3 +-
 scripts/qapi/doc.py                     |  4 +-
 scripts/qapi/expr.py                    | 35 +++++++-----
 scripts/qapi/introspect.py              |  7 ++-
 scripts/qapi/schema.py                  | 22 ++++++--
 tests/qapi-schema/doc-good.json         | 17 +++++-
 tests/qapi-schema/doc-good.out          |  9 ++-
 tests/qapi-schema/event-case.out        |  2 +-
 tests/qapi-schema/indented-expr.out     |  4 +-
 tests/qapi-schema/qapi-schema-test.json | 18 ++++++
 tests/qapi-schema/qapi-schema-test.out  | 75 ++++++++++++++++---------
 tests/qapi-schema/test-qapi.py          | 20 ++++---
 17 files changed, 219 insertions(+), 68 deletions(-)
Signature · 1 line
2.21.0