Skip to content

Enable more iotests during "make check-block"

Thomas Huth qemu-devel 5 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 4 repliesApplied
  2. v46 patches 8 repliesSuperseded
  3. v36 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches1 replySuperseded
v15 patches8 repliesSuperseded

Changes in v5 from the cover letter

- Added $python_unusable_because text in the fifth patch
- Rebased to master and checked that everything still works fine on Travis-CI, Cirrus-CI, Gitlab-CI, OpenBSD and NetBSD.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/6iotests: remove 'linux' from default supported platformstests/qemu-iotests/iotests.py+11 -50 replies
2/6iotests: Test 041 only works on certain systemstests/qemu-iotests/041+2 -10 replies
3/6iotests: Test 183 does not work on macOS and OpenBSDtests/qemu-iotests/183+1 -00 replies
4/6iotests: Check for the availability of the required devices in 267 and 127tests/qemu-iotests/127 tests/qemu-iotests/267 tests/qemu-iotests/common.rc+18 -00 replies
5/6iotests: Skip Python-based tests if QEMU does not support virtio-blktests/qemu-iotests/check+10 -23 replies
6/6iotests: Enable more tests in the 'auto' group to improve test coveragetests/qemu-iotests/group+7 -70 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMax ReitzPhilippe Mathieu-Daudé
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] Enable more iotests during "make check-block"

As discussed here:

https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html

and here:

https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html

it would be good to have some more valuable iotests enabled in the "auto" group to get better iotest coverage during "make check".

Since these Python-based tests require a QEMU that features a 'virtio-blk' device, we can only run the Python tests if this device is available. With binaries like qemu-system-tricore, the Python-based tests will be skipped.

v5:
- Added $python_unusable_because text in the fifth patch
- Rebased to master and checked that everything still works fine on Travis-CI, Cirrus-CI, Gitlab-CI, OpenBSD and NetBSD.

v4:
- The check for 'virtio-blk' is now done in the tests/qemu-iotests/check script instead of tests/check-block.sh (to avoid to duplicate the code that searches for the right QEMU binary - and we can also still run the shell-based tests this way).
- Added the new patch to check for the availability of virtio devices in the iotests 127 and 267.
- The patch that drops test 130 from the "auto" group has already been merged and thus been dropped from this series.

v3:
- Test 183 fails on Patchew, so I removed it from the "auto" group again

v2:
- Checked the iotests with NetBSD, too (now that Eduardo has re-activated Gerd's patches for creating NetBSD VM images)
- Use 'openbsd' instead of 'openbsd6'
- Use 'grep -q' instead of 'grep' for grep'ing silently
- Added the patch to disable 130 from the "auto" group

John Snow (1):
iotests: remove 'linux' from default supported platforms

Thomas Huth (5):
iotests: Test 041 only works on certain systems
iotests: Test 183 does not work on macOS and OpenBSD
iotests: Check for the availability of the required devices in 267 and

    127

iotests: Skip Python-based tests if QEMU does not support virtio-blk
iotests: Enable more tests in the 'auto' group to improve test
coverage

 tests/qemu-iotests/041        |  3 ++-
 tests/qemu-iotests/127        |  2 ++
 tests/qemu-iotests/183        |  1 +
 tests/qemu-iotests/267        |  2 ++
 tests/qemu-iotests/check      | 12 ++++++++++--
 tests/qemu-iotests/common.rc  | 14 ++++++++++++++
 tests/qemu-iotests/group      | 14 +++++++-------
 tests/qemu-iotests/iotests.py | 16 +++++++++++-----
 8 files changed, 49 insertions(+), 15 deletions(-)
Signature · 1 line
2.18.1