Enable more iotests during "make check-block"
Status from this message: Thanks, applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 4 repliesApplied
- v46 patches 8 repliesSuperseded
- v36 patches 14 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 6 patches | 1 reply | Superseded | |
| v1 | 5 patches | 8 replies | Superseded |
Changes in v5 from the cover letter
- Added $python_unusable_because text in the fifth patch
- Rebased to master and checked that everything still works fine on Travis-CI, Cirrus-CI, Gitlab-CI, OpenBSD and NetBSD.
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | iotests: remove 'linux' from default supported platformstests/ | +11 | 0 replies | |
| 2/6 | iotests: Test 041 only works on certain systemstests/ | +2 | 0 replies | |
| 3/6 | iotests: Test 183 does not work on macOS and OpenBSDtests/ | +1 | 0 replies | |
| 4/6 | iotests: Check for the availability of the required devices in 267 and 127tests/ tests/ tests/ | +18 | 0 replies | |
| 5/6 | iotests: Skip Python-based tests if QEMU does not support virtio-blktests/ | +10 | 3 replies | |
| 6/6 | iotests: Enable more tests in the 'auto' group to improve test coveragetests/ | +7 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Max Reitz | Philippe Mathieu-Daudé |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | |
| 3/6 | R-b | |
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/6] Enable more iotests during "make check-block"
As discussed here:
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html
and here:
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html
it would be good to have some more valuable iotests enabled in the "auto" group to get better iotest coverage during "make check".
Since these Python-based tests require a QEMU that features a 'virtio-blk' device, we can only run the Python tests if this device is available. With binaries like qemu-system-tricore, the Python-based tests will be skipped.
v5:
- Added $python_unusable_because text in the fifth patch
- Rebased to master and checked that everything still works fine on Travis-CI, Cirrus-CI, Gitlab-CI, OpenBSD and NetBSD.
v4:
- The check for 'virtio-blk' is now done in the tests/qemu-iotests/check script instead of tests/check-block.sh (to avoid to duplicate the code that searches for the right QEMU binary - and we can also still run the shell-based tests this way).
- Added the new patch to check for the availability of virtio devices in the iotests 127 and 267.
- The patch that drops test 130 from the "auto" group has already been merged and thus been dropped from this series.
v3:
- Test 183 fails on Patchew, so I removed it from the "auto" group again
v2:
- Checked the iotests with NetBSD, too (now that Eduardo has re-activated Gerd's patches for creating NetBSD VM images)
- Use 'openbsd' instead of 'openbsd6'
- Use 'grep -q' instead of 'grep' for grep'ing silently
- Added the patch to disable 130 from the "auto" group
John Snow (1):
iotests: remove 'linux' from default supported platforms
Thomas Huth (5):
iotests: Test 041 only works on certain systems
iotests: Test 183 does not work on macOS and OpenBSD
iotests: Check for the availability of the required devices in 267 and
127
iotests: Skip Python-based tests if QEMU does not support virtio-blk
iotests: Enable more tests in the 'auto' group to improve test
coverage
tests/qemu-iotests/041 | 3 ++- tests/qemu-iotests/127 | 2 ++ tests/qemu-iotests/183 | 1 + tests/qemu-iotests/267 | 2 ++ tests/qemu-iotests/check | 12 ++++++++++-- tests/qemu-iotests/common.rc | 14 ++++++++++++++ tests/qemu-iotests/group | 14 +++++++------- tests/qemu-iotests/iotests.py | 16 +++++++++++----- 8 files changed, 49 insertions(+), 15 deletions(-)
Signature · 1 line
2.18.1