Skip to content

qemu-img/io/nbd: Support help options for --object

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vl: Split off user_creatable_print_help()include/qom/object_interfaces.h qom/object_interfaces.c vl.c+74 -513 replies
2/4qemu-io: Support help options for --objectqemu-io.c+8 -11 reply
3/4qemu-img: Support help options for --objectqemu-img.c+21 -131 reply
4/4qemu-nbd: Support help options for --objectqemu-nbd.c+8 -12 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] qemu-img/io/nbd: Support help options for --object

This series fixes that the tools don't consider help options for --object and just treat them as regular object properties. For example:

    $ ./qemu-io --object secret,help
    qemu-io: Parameter 'id' is missing

With these patches, we get the expected behaviour like in the system emulator.

Kevin Wolf (4):
vl: Split off user_creatable_print_help()
qemu-io: Support help options for --object
qemu-img: Support help options for --object
qemu-nbd: Support help options for --object

 include/qom/object_interfaces.h | 12 +++++++
 qemu-img.c                      | 34 +++++++++++-------
 qemu-io.c                       |  9 ++++-
 qemu-nbd.c                      |  9 ++++-
 qom/object_interfaces.c         | 61 +++++++++++++++++++++++++++++++++
 vl.c                            | 52 +---------------------------
 6 files changed, 111 insertions(+), 66 deletions(-)
Signature · 1 line
2.20.1