Skip to content

xtensa: fix {get,put}_user() for 64bit values

Max Filippov lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v24 patches 0 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- fix assembly argument constraint for error code
- rearrange result zero-initialization for error paths in __get_user_asm

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xtensa: fix {get,put}_user() for 64bit valuesarch/xtensa/include/asm/uaccess.h+11 -20 replies
2/3xtensa: clean up assembly arguments in uaccess macrosarch/xtensa/include/asm/uaccess.h+21 -210 replies
3/3xtensa: fix type conversion in __get_user_[no]checkarch/xtensa/include/asm/uaccess.h+29 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] xtensa: fix {get,put}_user() for 64bit values

Hello,

this series fixes return value, out-of-bound stack access and value truncation in xtensa implementation of {get,put}_user() for 64bit values. It also cleans up naming of assembly parameters in __{get,put}_user_asm and __check_align_{1,2,4}.

Changes v2->v3:
- fix assembly argument constraint for error code
- rearrange result zero-initialization for error paths in __get_user_asm

Changes v1->v2:
- initialize result when access_ok check fails in __get_user_check
- initialize result in __get_user_asm for unaligned access

Al Viro (1):
xtensa: fix {get,put}_user() for 64bit values

Max Filippov (2):
xtensa: clean up assembly arguments in uaccess macros
xtensa: fix type conversion in __get_user_[no]check

 arch/xtensa/include/asm/uaccess.h | 94 +++++++++++++++++--------------
 1 file changed, 53 insertions(+), 41 deletions(-)
Signature · 1 line
2.20.1