Skip to content

tracing: Fix tracefs lockdown and various clean ups

Steven Rostedt linux-api linux-security-module lkml selinux stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 7 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tracefs: Revert ccbd54ff54e8 ("tracefs: Restrict tracefs when the kernel is locked down")fs/tracefs/inode.c+1 -413 replies
2/7ftrace: Get a reference counter for the trace_array on filter fileskernel/trace/ftrace.c+18 -90 replies
3/7tracing: Get trace_array reference for available_tracers fileskernel/trace/trace.c+15 -20 replies
4/7tracing: Have trace events system open call tracing_open_generic_tr()kernel/trace/trace.c kernel/trace/trace.h kernel/trace/trace_events.c+7 -271 reply
5/7tracing: Add tracing_check_open_get_tr()kernel/trace/ftrace.c kernel/trace/trace.c kernel/trace/trace.h +3 more+81 -600 replies
6/7tracing: Add some more locked_down checkskernel/trace/ftrace.c kernel/trace/trace.c kernel/trace/trace_events.c +7 more+98 -40 replies
7/7tracing: Do not create tracefs files if tracefs lockdown is in effectfs/tracefs/inode.c+4 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/7 v2] tracing: Fix tracefs lockdown and various clean ups

It appears that using destroy_inode() to clean up the proxy_ops that was used by the lockdown code to have all open calls to the tracefs directory was totally broken. It caused the inodes to not be cleaned up as the destroy_inode() method is expected to clean up the inode, and not just what it allocated as extra.

Linus suggested to get rid of the proxy_ops in tracefs, and just put the checks in the open functions themselves. This also gives us a bit more fine grain control to what exactly can be accessed.

Currently, I left the event format files (as they may need to be used by something other than tracing), and enabled_functions, which shows what functions are currently being traced. Not sure it is wise to not display that information.

They can always be locked down later if need be.

Steven Rostedt (VMware) (7):
tracefs: Revert ccbd54ff54e8 ("tracefs: Restrict tracefs when the kernel is locked down")
ftrace: Get a reference counter for the trace_array on filter files
tracing: Get trace_array reference for available_tracers files
tracing: Have trace events system open call tracing_open_generic_tr()
tracing: Add tracing_check_open_get_tr()
tracing: Add some more locked_down checks
tracing: Do not create tracefs files if tracefs lockdown is in effect

----

 fs/tracefs/inode.c                  |  46 ++----------
 kernel/trace/ftrace.c               |  55 ++++++++++----
 kernel/trace/trace.c                | 138 ++++++++++++++++++++++--------------
 kernel/trace/trace.h                |   2 +
 kernel/trace/trace_dynevent.c       |   4 ++
 kernel/trace/trace_events.c         |  49 +++++--------
 kernel/trace/trace_events_hist.c    |  13 +++-
 kernel/trace/trace_events_trigger.c |   8 ++-
 kernel/trace/trace_kprobe.c         |  12 +++-
 kernel/trace/trace_printk.c         |   7 ++
 kernel/trace/trace_stack.c          |   8 +++
 kernel/trace/trace_stat.c           |   6 +-
 kernel/trace/trace_uprobe.c         |  11 +++
 13 files changed, 220 insertions(+), 139 deletions(-)