Skip to content

crypto: s390 - convert to skcipher API

Eric Biggers linux-crypto linux-s390 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3crypto: s390/aes - convert to skcipher APIarch/s390/crypto/aes_s390.c+234 -3751 reply
2/3crypto: s390/paes - convert to skcipher APIarch/s390/crypto/paes_s390.c+174 -2403 replies
3/3crypto: s390/des - convert to skcipher APIarch/s390/crypto/des_s390.c+172 -2471 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArd BiesheuvelHarald Freudenberger
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFT PATCH 0/3] crypto: s390 - convert to skcipher API

This series converts the glue code for the S390 CPACF implementations of AES, DES, and 3DES modes from the deprecated "blkcipher" API to the "skcipher" API. This is needed in order for the blkcipher API to be removed.

I've compiled this patchset, and the conversion is very similar to that which has been done for many other crypto drivers. But I don't have the hardware to test it, nor is S390 CPACF supported by QEMU. So I really need someone with the hardware to test it. You can do so by setting:

CONFIG_CRYPTO_HW=y
CONFIG_ZCRYPT=y
CONFIG_PKEY=y
CONFIG_CRYPTO_AES_S390=y
CONFIG_CRYPTO_PAES_S390=y
CONFIG_CRYPTO_DES_S390=y
# CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
CONFIG_DEBUG_KERNEL=y
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
CONFIG_CRYPTO_AES=y
CONFIG_CRYPTO_DES=y
CONFIG_CRYPTO_CBC=y
CONFIG_CRYPTO_CTR=y
CONFIG_CRYPTO_ECB=y
CONFIG_CRYPTO_XTS=y

Then boot and check for crypto self-test failures by running 'dmesg | grep alg'.

If there are test failures, please also check whether they were already failing prior to this patchset.

This won't cover the "paes" ("protected key AES") algorithms, however, since those don't have self-tests. If anyone has any way to test those, please do so.

Eric Biggers (3):
crypto: s390/aes - convert to skcipher API
crypto: s390/paes - convert to skcipher API
crypto: s390/des - convert to skcipher API

 arch/s390/crypto/aes_s390.c  | 609 ++++++++++++++---------------------
 arch/s390/crypto/des_s390.c  | 419 ++++++++++--------------
 arch/s390/crypto/paes_s390.c | 414 ++++++++++--------------
 3 files changed, 580 insertions(+), 862 deletions(-)
Signature · 1 line
2.23.0