post-build: pass an empty rootpath to genimage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | support/scripts/genimage.sh: pass an empty rootpath to genimagesupport/ | +9 | 1 reply | |
| 1/9 | support/scripts/genimage.sh: pass an empty rootpath to genimage | +0 | 1 reply | |
| 1/9 | support/scripts/genimage.sh: pass an empty rootpath to genimage | +0 | 0 replies | |
| 2/9 | configs/beagleboardx15: drop custom post-image scriptboard/ configs/ | +2 | 0 replies | |
| 3/9 | configs/beaglebone: don't use custom post-image scriptboard/ configs/ | +7 | 0 replies | |
| 4/9 | configs/minnowboard_max-graphical: don't use custom post-image scriptconfigs/ | +2 | 0 replies | |
| 5/9 | configs/minnowboard_max: drop custom post-image scriptboard/ configs/ | +2 | 0 replies | |
| 6/9 | configs/pandaboard: drop custom post-image scriptboard/ configs/ | +2 | 0 replies | |
| 7/9 | board/raspberrypi/post-image.sh: pass an empty rootpath to genimageboard/ | +10 | 0 replies | |
| 8/9 | configs/roseapplepi: drop custom post-image scriptboard/ board/ configs/ | +7 | 0 replies | |
| 9/9 | configs/wandboard: drop custom post-image scriptboard/ configs/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/9] post-build: pass an empty rootpath to genimage
From: Carlos Santos <[email protected]>
genimage makes a full copy of the given rootpath to ${GENIMAGE_TMP}/root so passing TARGET_DIR is a waste of time and disk space. We don't rely on genimage to build rootfs images, just to insert pre-built images in the disk images.
The waste may be negligible for sporadic builds but becomes relevant if we think about autobuilders that perform several builds everyday.
Patch 1 changes support/scripts/genimage.sh to pass an empty rootpath to genimage.
Patches 2-6, 8 and 9 drop per-board scripts and use genimage.sh, passing the corresponding configuration file via BR2_ROOTFS_POST_SCRIPT_ARGS.
Patch 7 makes the same change in board/raspberrypi/post-image.sh. This script cannot be directly replaced by genimage.sh
because it does other things.
The board/beaglebone/post-image.sh script was not removed because it is used by beaglebone_qt5_defconfig, which is currently broken and cannot be tested.
Again, these changes may appear to be overkill but since Buildroot is an open source project each piece of code becomes a potential learning tool for other developers. We must strive to provide good examples.
Carlos Santos (9):
support/scripts/genimage.sh: pass an empty rootpath to genimage configs/beagleboardx15: drop custom post-image script configs/beaglebone: don't use custom post-image script configs/minnowboard_max-graphical: don't use custom post-image script configs/minnowboard_max: drop custom post-image script configs/pandaboard: drop custom post-image script board/raspberrypi/post-image.sh: pass an empty rootpath to genimage configs/roseapplepi: drop custom post-image script configs/wandboard: drop custom post-image script
board/beagleboardx15/post-image.sh | 15 --------------- board/beaglebone/post-build.sh | 4 ++++ board/minnowboard/post-image.sh | 13 ------------- board/pandaboard/post-image.sh | 16 ---------------- board/raspberrypi/post-image.sh | 12 ++++++++++-- board/roseapplepi/post-build.sh | 4 ++++ board/roseapplepi/post-image.sh | 18 ------------------ board/wandboard/post-image.sh | 15 --------------- configs/beagleboardx15_defconfig | 3 ++- configs/beaglebone_defconfig | 4 +++- configs/minnowboard_max-graphical_defconfig | 3 ++- configs/minnowboard_max_defconfig | 3 ++- configs/pandaboard_defconfig | 3 ++- configs/roseapplepi_defconfig | 4 +++- configs/wandboard_defconfig | 3 ++- support/scripts/genimage.sh | 10 +++++++++- 16 files changed, 43 insertions(+), 87 deletions(-) delete mode 100755 board/beagleboardx15/post-image.sh create mode 100755 board/beaglebone/post-build.sh delete mode 100755 board/minnowboard/post-image.sh delete mode 100755 board/pandaboard/post-image.sh create mode 100755 board/roseapplepi/post-build.sh delete mode 100755 board/roseapplepi/post-image.sh delete mode 100755 board/wandboard/post-image.sh
Signature · 1 line
2.18.1