Skip to content

perf tools: Share struct map after clone

Jiri Olsa lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review
  2. v13 patches 7 repliesApplied

Changes in v2 from the cover letter

- rebased to Arnaldo's perf/core
- patch 1 already taken

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf tools: Separate shareable part of 'struct map' into 'struct map_shared'tools/perf/arch/arm/tests/dwarf-unwind.c tools/perf/arch/arm64/tests/dwarf-unwind.c tools/perf/arch/powerpc/tests/dwarf-unwind.c +53 more+489 -4440 replies
2/2perf tools: Make 'struct map_shared' truly sharedtools/perf/util/map.c tools/perf/util/map.h tools/perf/util/symbol.c+55 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/2] perf tools: Share struct map after clone

hi,
Andi reported that maps cloning is eating lot of memory and it's probably unnecessary, because they keep the same data.

This 'maps sharing' seems to save lot of heap for reports with many forks/cloned mmaps (over 60% in example below).

Profile kernel build:

  $ perf record make -j 40

Get heap profile (tools/perf directory):

  $ <install gperftools>
  $ make TCMALLOC=1
  $ HEAPPROFILE=/tmp/heapprof ./perf report -i perf.data --stdio > out
  $ pprof ./perf /tmp/heapprof.000*

Before:

(pprof) top
Total: 2335.5 MB

    1735.1  74.3%  74.3%   1735.1  74.3% memdup
     402.0  17.2%  91.5%    402.0  17.2% zalloc
     140.2   6.0%  97.5%    145.8   6.2% map__new
      33.6   1.4%  98.9%     33.6   1.4% symbol__new
      12.4   0.5%  99.5%     12.4   0.5% alloc_event
       6.2   0.3%  99.7%      6.2   0.3% nsinfo__new
       5.5   0.2% 100.0%      5.5   0.2% nsinfo__copy
       0.3   0.0% 100.0%      0.3   0.0% dso__new
       0.1   0.0% 100.0%      0.1   0.0% do_read_string
       0.0   0.0% 100.0%      0.0   0.0% __GI__IO_file_doallocate

After:

(pprof) top
Total: 784.5 MB

     385.8  49.2%  49.2%    385.8  49.2% memdup
     285.8  36.4%  85.6%    285.8  36.4% zalloc
      80.4  10.3%  95.9%     83.7  10.7% map__new
      19.1   2.4%  98.3%     19.1   2.4% symbol__new
       6.2   0.8%  99.1%      6.2   0.8% alloc_event
       3.6   0.5%  99.6%      3.6   0.5% nsinfo__new
       3.2   0.4% 100.0%      3.2   0.4% nsinfo__copy
       0.2   0.0% 100.0%      0.2   0.0% dso__new
       0.0   0.0% 100.0%      0.0   0.0% do_read_string
       0.0   0.0% 100.0%      0.0   0.0% elf_fill

v2 changes:
- rebased to Arnaldo's perf/core
- patch 1 already taken

Also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/map_shared

thanks,
jirka

---
Jiri Olsa (2):
perf tools: Separate shareable part of 'struct map' into 'struct map_shared' perf tools: Make 'struct map_shared' truly shared

 tools/perf/arch/arm/tests/dwarf-unwind.c               |   2 +-
 tools/perf/arch/arm64/tests/dwarf-unwind.c             |   2 +-
 tools/perf/arch/powerpc/tests/dwarf-unwind.c           |   2 +-
 tools/perf/arch/powerpc/util/skip-callchain-idx.c      |   4 +--
 tools/perf/arch/powerpc/util/sym-handling.c            |   4 +--
 tools/perf/arch/s390/annotate/instructions.c           |   2 +-
 tools/perf/arch/x86/tests/dwarf-unwind.c               |   2 +-
 tools/perf/arch/x86/util/event.c                       |   6 ++--
 tools/perf/builtin-annotate.c                          |   8 +++---
 tools/perf/builtin-inject.c                            |  10 ++++---
 tools/perf/builtin-kallsyms.c                          |   7 +++--
 tools/perf/builtin-kmem.c                              |   2 +-
 tools/perf/builtin-mem.c                               |   6 ++--
 tools/perf/builtin-report.c                            |  19 +++++++------
 tools/perf/builtin-script.c                            |  16 +++++------
 tools/perf/builtin-top.c                               |  15 +++++-----
 tools/perf/builtin-trace.c                             |   2 +-
 tools/perf/tests/code-reading.c                        |  34 ++++++++++++-----------
 tools/perf/tests/hists_common.c                        |   4 +--
 tools/perf/tests/hists_cumulate.c                      |   4 +--
 tools/perf/tests/hists_filter.c                        |   4 +--
 tools/perf/tests/hists_output.c                        |   2 +-
 tools/perf/tests/map_groups.c                          |  22 +++++++--------
 tools/perf/tests/mmap-thread-lookup.c                  |   2 +-
 tools/perf/tests/vmlinux-kallsyms.c                    |  36 ++++++++++++------------
 tools/perf/ui/browsers/annotate.c                      |   4 +--
 tools/perf/ui/browsers/hists.c                         |  10 +++----
 tools/perf/ui/browsers/map.c                           |   4 +--
 tools/perf/ui/gtk/annotate.c                           |   2 +-
 tools/perf/util/annotate.c                             |  34 +++++++++++------------
 tools/perf/util/auxtrace.c                             |   2 +-
 tools/perf/util/bpf-event.c                            |   8 +++---
 tools/perf/util/build-id.c                             |   2 +-
 tools/perf/util/callchain.c                            |   6 ++--
 tools/perf/util/db-export.c                            |   4 +--
 tools/perf/util/dso.c                                  |   2 +-
 tools/perf/util/event.c                                |   6 ++--
 tools/perf/util/evsel_fprintf.c                        |   2 +-
 tools/perf/util/hist.c                                 |  10 +++----
 tools/perf/util/intel-pt.c                             |  42 ++++++++++++++++------------
 tools/perf/util/machine.c                              |  76 +++++++++++++++++++++++++-------------------------
 tools/perf/util/map.c                                  | 226 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------
 tools/perf/util/map.h                                  |  32 +++++++++++++--------
 tools/perf/util/probe-event.c                          |  32 ++++++++++-----------
 tools/perf/util/scripting-engines/trace-event-perl.c   |   8 +++---
 tools/perf/util/scripting-engines/trace-event-python.c |  12 ++++----
 tools/perf/util/sort.c                                 |  58 ++++++++++++++++++++------------------
 tools/perf/util/symbol-elf.c                           |  28 +++++++++----------
 tools/perf/util/symbol.c                               |  80 ++++++++++++++++++++++++++---------------------------
 tools/perf/util/symbol_fprintf.c                       |   2 +-
 tools/perf/util/synthetic-events.c                     |  14 +++++-----
 tools/perf/util/thread.c                               |  14 +++++-----
 tools/perf/util/unwind-libdw.c                         |  16 +++++++----
 tools/perf/util/unwind-libunwind-local.c               |  37 +++++++++++++------------
 tools/perf/util/unwind-libunwind.c                     |   4 +--
 tools/perf/util/vdso.c                                 |   2 +-
 56 files changed, 540 insertions(+), 456 deletions(-)