Skip to content

gup.c, gup_benchmark.c trivial fixes before the storm

John Hubbard linux-kselftest linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 7 repliesSuperseded

Changes in v2 from the cover letter

1) Fixed a krobot-reported mistake, which also uncovered a pre-existing bug. Thanks to Kirill for recommending the fix.

2) Added another small fix: changed the data type to unsigned int, as pointed out by Ira.

2) Added a "Fixes:" line, thanks to Kirill and Aneesh for pinpointing the commit.

3) Collected Acked-by and Suggested-by's.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm/gup_benchmark: add a missing "w" to getopt stringtools/testing/selftests/vm/gup_benchmark.c+1 -10 replies
2/2mm/gup: fix a misnamed "write" argument, and a related bugmm/gup.c+8 -61 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKirill A. ShutemovIra Weiny
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] gup.c, gup_benchmark.c trivial fixes before the storm

Hi,

Changes since v1:

1) Fixed a krobot-reported mistake, which also uncovered a pre-existing bug. Thanks to Kirill for recommending the fix.

2) Added another small fix: changed the data type to unsigned int, as pointed out by Ira.

2) Added a "Fixes:" line, thanks to Kirill and Aneesh for pinpointing the commit.

3) Collected Acked-by and Suggested-by's.

Original cover letter, edited slightly
======================================

These trivial fixes apply to today's linux.git (5.4-rc3).

I found these while polishing up the Next And Final get_user_pages()+dma tracking patchset (which is in final testing and passing nicely...so far).

Anyway, as these two patches apply cleanly both before and after the larger gup/dma upcoming patchset, I thought it best to send this out separately, in order to avoid muddying the waters more than usual.

Cc Christoph Hellwig <[email protected]>
Cc Aneesh Kumar K.V <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
Cc Keith Busch <[email protected]>
Cc Ira Weiny <[email protected]>
Cc Shuah Khan <[email protected]>

John Hubbard (2):
mm/gup_benchmark: add a missing "w" to getopt string mm/gup: fix a misnamed "write" argument, and a related bug

 mm/gup.c                                   | 14 ++++++++------
 tools/testing/selftests/vm/gup_benchmark.c |  2 +-
 2 files changed, 9 insertions(+), 7 deletions(-)
Signature · 1 line
2.23.0