Skip to content

gpio: pca953x: Convert to bitmap (extended) API

Andy Shevchenko linux-gpio lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 6 repliesIn review
  2. v11 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11lib/test_bitmap: Force argument of bitmap_parselist_user() to proper address spacelib/test_bitmap.c+1 -10 replies
2/11lib/test_bitmap: Undefine macros after uselib/test_bitmap.c+4 -00 replies
3/11lib/test_bitmap: Name EXP_BYTES properlylib/test_bitmap.c+5 -50 replies
4/11lib/test_bitmap: Rename exp to exp1 to avoid ambiguous namelib/test_bitmap.c+22 -220 replies
5/11lib/test_bitmap: Move exp1 and exp2 upper for others to uselib/test_bitmap.c+20 -210 replies
6/11lib/test_bitmap: Fix comment about this filelib/test_bitmap.c+1 -10 replies
7/11bitmap: Introduce bitmap_replace() helperinclude/linux/bitmap.h lib/bitmap.c lib/test_bitmap.c+66 -02 replies
8/11gpio: pca953x: Remove redundant variable and check in IRQ handlerdrivers/gpio/gpio-pca953x.c+1 -30 replies
9/11gpio: pca953x: Use input from regs structure in pca953x_irq_pending()drivers/gpio/gpio-pca953x.c+1 -10 replies
10/11gpio: pca953x: Convert to use bitmap APIdrivers/gpio/gpio-pca953x.c+73 -953 replies
11/11gpio: pca953x: Tight up indentationdrivers/gpio/gpio-pca953x.c+11 -110 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus Walleij
SeriesA-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] gpio: pca953x: Convert to bitmap (extended) API

While converting gpio-pca953x driver to bitmap API, I noticed that we have no function to replace bits.

So, that's how patch 7 appears.

First 6 patches are preparatory of the test suite (including some warning fixes, etc).

Patches 8-9 are preparatory for the GPIO driver to be easier converted to bitmap API, conversion to which happens in patch 10.

Patch 11 simple indentation fixes.

Since the series depends to the commit e51819d749db ("bitops: introduce the for_each_set_clump8 macro") in Andrew's set and taking into consideration a lot of bitmap related patches here, it would make sense to route these thru Andrew as well.

In v2:
- address wrong logic in pca953x_gpio_set_multiple() (William)
- 10 more patches as described above

Andy Shevchenko (11):
lib/test_bitmap: Force argument of bitmap_parselist_user() to proper
address space
lib/test_bitmap: Undefine macros after use lib/test_bitmap: Name EXP_BYTES properly
lib/test_bitmap: Rename exp to exp1 to avoid ambiguous name lib/test_bitmap: Move exp1 and exp2 upper for others to use lib/test_bitmap: Fix comment about this file
bitmap: Introduce bitmap_replace() helper
gpio: pca953x: Remove redundant variable and check in IRQ handler
gpio: pca953x: Use input from regs structure in pca953x_irq_pending()
gpio: pca953x: Convert to use bitmap API
gpio: pca953x: Tight up indentation

 drivers/gpio/gpio-pca953x.c | 196 ++++++++++++++++--------------------
 include/linux/bitmap.h      |  16 +++
 lib/bitmap.c                |  12 +++
 lib/test_bitmap.c           | 137 ++++++++++++++++---------
 4 files changed, 203 insertions(+), 158 deletions(-)
Signature · 1 line
2.23.0