Skip to content

mptcp: add primitive scheduler

Florian Westphal mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 6 repliesIn review
  2. v2 posting 1/24 patches 9 repliesSuperseded
  3. v1 RFC6 patches 6 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mptcp: add and use mptcp_subflow_get_retransnet/mptcp/protocol.c+32 -10 replies
2/2mptcp: sendmsg: transmit on backup if other subflows have been closednet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+68 -93 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [MPTCP] [PATCH v2 0/2] mptcp: add primitive scheduler

This is a simplified version of a sendmsg ssk selection strategy, so sendmsg or retransmit could also occur on a backup subflow.

In the initial submission it was pointed out that we should not send more data when a retransmission is happening.

As this isn't directly related to this I've decided to send those two patches now and work on sendmsg moderation next.

The plan is to add wmem_queued accounting to the mptcp socket and then make sendmsg/mptcp_poll consider mptcp socket wmem limits to avoid sending more data if there are no mptcp-level acknowledgements.

This however might take some time because msk->ack_seq update occurs only at recvmsg time and not during mptcp ack processing.
For this to work properly, mptcp-level ack update should not depend on a recvmsg call.

The following changes since commit dcb69525165804b78e07ed7875d33463a3fde7c8:

subflow: wake parent mptcp socket on subflow state change (2019-10-30 02:24:34 +0000)

are available in the Git repository at:

git://git.breakpoint.cc/fw/mptcp-next.git sendmsg_refactor_19

for you to fetch changes up to a1cb9992e1f55156914dc0e6727f92463fb96938:

mptcp: sendmsg: transmit on backup if other subflows have been closed (2019-10-30 14:42:48 +0100)

----------------------------------------------------------------
Florian Westphal (2):
mptcp: add and use mptcp_subflow_get_retrans
mptcp: sendmsg: transmit on backup if other subflows have been closed

 net/mptcp/protocol.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++-----
 net/mptcp/protocol.h |   1 +
 net/mptcp/subflow.c  |   7 +++-
 3 files changed, 100 insertions(+), 10 deletions(-)