Skip to content

apic: Fix migration breakage of >255 vcpus

Peter Xu qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 14 repliesIn review
  2. v12 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- use uint32_t rather than int64_t [Juan]
- one more patch (patch 4) to check dup SaveStateEntry [Dave]
- one more patch to define a macro (patch 1) to simplify patch 2

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4migration: Define VMSTATE_INSTANCE_ID_ANYhw/arm/stellaris.c hw/core/qdev.c hw/display/ads7846.c +11 more+21 -161 reply
2/4migration: Change SaveStateEntry.instance_id into uint32_thw/intc/apic_common.c include/migration/register.h include/migration/vmstate.h +2 more+16 -141 reply
3/4apic: Use 32bit APIC ID for migration instance IDhw/intc/apic_common.c+4 -12 replies
4/4migration: Check in savevm_state_handler_insert for dupsmigration/savevm.c+14 -03 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEduardo HabkostJuan QuintelaDr. David Alan Gilbert
1/4R-b
2/4R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

v2:
- use uint32_t rather than int64_t [Juan]
- one more patch (patch 4) to check dup SaveStateEntry [Dave]
- one more patch to define a macro (patch 1) to simplify patch 2

Please review, thanks.

Peter Xu (4):
migration: Define VMSTATE_INSTANCE_ID_ANY
migration: Change SaveStateEntry.instance_id into uint32_t
apic: Use 32bit APIC ID for migration instance ID
migration: Check in savevm_state_handler_insert for dups

 hw/arm/stellaris.c           |  2 +-
 hw/core/qdev.c               |  3 ++-
 hw/display/ads7846.c         |  2 +-
 hw/i2c/core.c                |  2 +-
 hw/input/stellaris_input.c   |  3 ++-
 hw/intc/apic_common.c        |  7 +++++--
 hw/misc/max111x.c            |  2 +-
 hw/net/eepro100.c            |  2 +-
 hw/pci/pci.c                 |  2 +-
 hw/ppc/spapr.c               |  2 +-
 hw/timer/arm_timer.c         |  2 +-
 hw/tpm/tpm_emulator.c        |  3 ++-
 include/migration/register.h |  2 +-
 include/migration/vmstate.h  |  6 ++++--
 migration/savevm.c           | 40 +++++++++++++++++++++++++-----------
 stubs/vmstate.c              |  2 +-
 16 files changed, 53 insertions(+), 29 deletions(-)
Signature · 1 line
2.21.0