import x509/pkcs7 parsers from linux
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 11 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 11 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux
Quoted 7 lines · Heinrich Schuchardt
Quoted 6 lines · AKASHI Takahiro
Quoted 5 lines · Heinrich Schuchardt
Quoted 3 lines · AKASHI Takahiro
I hope this patch set will be reviewed promptly as I'm aiming to push my "UEFI secure boot" patch for v2020.01.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
How can I make all of these new files being built to check for build warnings?
As always in my case of UEFI secure boot, they have gone through build and run/tests as part of UEFI secure boot. This is also true for RSA extension as UEFI secure boot is the only user of those features.
Did you run them through Travis?
As far as this patch set is concerned, no configuration enables any of kconfig options listed below and running Travis doesn't make sense.
-Takahiro Akashi
Quoted 51 lines
Quoted 14 lines
Please note that almost of all the code here come from the latest linux code without any changes. A few changes that I made are quite U-Boot/UEFI-secure-boot specific and is *best* tested through UEFI secure boot test.
That said, you can at least build the code by enabling
Library routines
Security support
Asymmetric Key Support
CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPECONFIG_X509_CERTIFICATE_PARSERCONFIG_PKCS7_MESSAGE_PARSERQuoted 4 lines
Quoted 1 line
Please, provide unit tests for the patch series.
As I said above, it will be exercised and tested under UEFI secure boot test.
If there is nothing I can test now, I would not know how to evaluate these patches.
There is good reason that we have unit tests and don't simply say U-Boot can be tested by booting Linux.
Quoted 7 lines
Quoted 3 lines
Please, provide a documentation how these different tools and files work together.
What do you mean by different tools?
Asn1 compiler and what?
Do you want to have doc/README.asn1compiler?This patch series provides some puzzle pieces but doesn't tell me how they fit together. Maybe a README describing the different elements provided for UEFI secure boot would be most appropriate.
Best regards
Heinrich
Quoted 9 lines
Thanks,
-Takahiro AkashiQuoted 3 lines
Best regards
Heinrich