Skip to content

A series of covscan-indicated fixes

Phil Sutter netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6obj: ct_timeout: Check return code of mnl_attr_parse_nested()src/obj/ct_timeout.c+6 -31 reply
2/6set_elem: Fix return code of nftnl_set_elem_set()src/set_elem.c+1 -11 reply
3/6set_elem: Validate nftnl_set_elem_set() parametersinclude/libnftnl/set.h src/set_elem.c+12 -05 replies
4/6set: Don't bypass checks in nftnl_set_set_u{32,64}()src/set.c+3 -25 replies
5/6obj/ct_timeout: Avoid array overrun in timeout_parse_attr_data()include/utils.h src/obj/ct_timeout.c+9 -17 replies
6/6obj/tunnel: Fix for undefined behavioursrc/obj/tunnel.c+3 -31 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPablo Neira Ayuso
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [libnftnl PATCH 0/6] A series of covscan-indicated fixes

Fix (potential) issues identified by Coverity tool.

Phil Sutter (6):
obj: ct_timeout: Check return code of mnl_attr_parse_nested()
set_elem: Fix return code of nftnl_set_elem_set()
set_elem: Validate nftnl_set_elem_set() parameters
set: Don't bypass checks in nftnl_set_set_u{32,64}() obj/ct_timeout: Avoid array overrun in timeout_parse_attr_data() obj/tunnel: Fix for undefined behaviour

 include/libnftnl/set.h |  2 ++
 include/utils.h        |  8 ++++++++
 src/obj/ct_timeout.c   | 11 +++++++----
 src/obj/tunnel.c       |  6 +++---
 src/set.c              |  5 +++--
 src/set_elem.c         | 12 +++++++++++-
 6 files changed, 34 insertions(+), 10 deletions(-)
Signature · 1 line
2.23.0