Skip to content

Clang compilation fixes

Bill Wendling kvm 2 versions Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 6 repliesApplied
  2. v2 posting 1/20 of 2 patches 0 repliesSuperseded

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2Use a status enum for reporting pass/faillib/libcflat.h lib/report.c+23 -144 replies
1/2lib: use a status enum for reporting pass/faillib/libcflat.h lib/report.c+23 -140 replies
2/2x86: use pointer for end of exception tablelib/x86/desc.c+2 -23 replies
2/2Use a status enum for reporting pass/faillib/libcflat.h lib/report.c+24 -140 replies
2/2x86: don't compare two global objects' addrs for inequalitylib/x86/desc.c+1 -12 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchThomas Huth
1/2
1/2
2/2R-b
2/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [kvm-unit-tests v2 PATCH 0/2] Clang compilation fixes

The attached patches have fixes for clang compilation and some failures seen from the previous "report()" fix.

The first, changing the "report()" function to accept an "enum status" instead of "unsigned pass" is under discussion, with others making alternative suggestions. I add the patch here for completeness, but you may want to wait until the discussion has settled.

The second, using "less than" to compare two global objects' addresses for inequality, should be less controversial.

This replaces the previous two patches I sent. I apologize for the spammage.

[kvm-unit-tests PATCH 1/2] Use a status enum for reporting pass/fail [kvm-unit-tests PATCH 2/2] x86: use pointer for end of exception table

Bill Wendling (2):
lib: use a status enum for reporting pass/fail
x86: don't compare two global objects' addrs for inequality

 lib/libcflat.h | 13 +++++++++++--
 lib/report.c   | 24 ++++++++++++------------
 lib/x86/desc.c |  2 +-
 3 files changed, 24 insertions(+), 15 deletions(-)
Signature · 1 line
2.23.0.700.g56cf767bdb-goog