Skip to content

Add Qemu to SeaBIOS LCHS interface

Sam Eiderman qemu-devel 1 version Applied

Status from this message: Thanks, applied to my IDE tree:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v8 Latest8 patches 7 repliesApplied

Changes in v8 from the cover letter

* Fixed BE issue with tests by using qfw_cfg_get_file() instead of read_fw_cfg_file(), thanks Laszlo.
* Removed incorrect comment in 7/8.

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/8block: Refactor macros - fix tabbinghw/ide/qdev.c include/hw/block/block.h+9 -90 replies
2/8block: Support providing LCHS from userinclude/hw/block/block.h+5 -11 reply
3/8bootdevice: Add interface to gather LCHSbootdevice.c include/sysemu/sysemu.h+58 -01 reply
4/8scsi: Propagate unrealize() callback to scsi-hdhw/scsi/scsi-bus.c include/hw/scsi/scsi.h+17 -01 reply
5/8bootdevice: Gather LCHS from all relevant deviceshw/block/virtio-blk.c hw/ide/qdev.c hw/scsi/scsi-disk.c+23 -01 reply
6/8bootdevice: Refactor get_boot_devices_listbootdevice.c+34 -271 reply
7/8bootdevice: FW_CFG interface for LCHS valuesbootdevice.c hw/nvram/fw_cfg.c include/sysemu/sysemu.h+43 -31 reply
8/8hd-geo-test: Add tests for lchs overridetests/Makefile.include tests/hd-geo-test.c+552 -10 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKarl HeubaumArbel MoshePhilippe Mathieu-Daudé
SeriesR-b R-b
1/8R-b R-b R-b
2/8R-b R-b R-b T-b
3/8R-b R-b R-b T-b
4/8R-b R-b R-b T-b
5/8R-b R-b R-b T-b
6/8R-b R-b R-b T-b
7/8R-b R-b R-b T-b T-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/8] Add Qemu to SeaBIOS LCHS interface

v1:

Non-standard logical geometries break under QEMU.

A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard logical geometries - for example 56 SPT (sectors per track). No matter what QEMU will guess - SeaBIOS, for large enough disks - will use LBA translation, which will report 63 SPT instead.

In addition we can not enforce SeaBIOS to rely on phyiscal geometries at all. A virtio-blk-pci virtual disk with 255 phyiscal heads can not report more than 16 physical heads when moved to an IDE controller, the ATA spec allows a maximum of 16 heads - this is an artifact of virtualization.

By supplying the logical geometies directly we are able to support such "exotic" disks.

We will use fw_cfg to do just that.

v2:

Fix missing parenthesis check in
"hd-geo-test: Add tests for lchs override"

v3:

* Rename fw_cfg key to "bios-geometry".
* Remove "extendible" interface.
* Add cpu_to_le32 fix as Laszlo suggested or big endian hosts
* Fix last qtest commit - automatic docker tester for some reason does not have qemu-img set

v4:

* Change fw_cfg interface from mixed textual/binary to textual only

v5:

* Fix line > 80 chars in tests/hd-geo-test.c

v6:

* Small fixes for issues pointed by Max
* (&conf->conf)->lcyls to conf->conf.lcyls and so on
* Remove scsi_unrealize from everything other than scsi-hd
* Add proper include to sysemu.h
* scsi_device_unrealize() after scsi_device_purge_requests()

v7:

* Adapted last commit (tests) to changes in qtest

v8:

* Fixed BE issue with tests by using qfw_cfg_get_file() instead of read_fw_cfg_file(), thanks Laszlo.
* Removed incorrect comment in 7/8.

Sam Eiderman (8):
block: Refactor macros - fix tabbing
block: Support providing LCHS from user
bootdevice: Add interface to gather LCHS
scsi: Propagate unrealize() callback to scsi-hd
bootdevice: Gather LCHS from all relevant devices
bootdevice: Refactor get_boot_devices_list
bootdevice: FW_CFG interface for LCHS values
hd-geo-test: Add tests for lchs override

 bootdevice.c             | 147 +++++++++--
 hw/block/virtio-blk.c    |   6 +
 hw/ide/qdev.c            |   7 +-
 hw/nvram/fw_cfg.c        |  14 +-
 hw/scsi/scsi-bus.c       |  16 ++
 hw/scsi/scsi-disk.c      |  12 +
 include/hw/block/block.h |  22 +-
 include/hw/scsi/scsi.h   |   1 +
 include/sysemu/sysemu.h  |   4 +
 tests/Makefile.include   |   2 +-
 tests/hd-geo-test.c      | 551 +++++++++++++++++++++++++++++++++++++++
 11 files changed, 741 insertions(+), 41 deletions(-)
Signature · 1 line
2.23.0.700.g56cf767bdb-goog