Skip to content

migration: faster savevm_state_handler_insert()

Scott Cheloha qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 14 repliesIn review

Changes in v2 from the cover letter

* Split patch 1 into 2 patches.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2migration: add savevm_state_handler_remove()migration/savevm.c+7 -22 replies
2/2migration: savevm_state_handler_insert: constant-time element insertionmigration/savevm.c+23 -312 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertJuan Quintela
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] migration: faster savevm_state_handler_insert()

The savevm_state.handlers queue of SaveStateEntry objects is a priority queue with an O(n) insertion cost. This is makes startup extremely slow when a VM has many such objects to register. For instance, a ppc64 VM with a large (8T+) maxmem needs to register tens of thousands of SaveStateEntry handlers: startup for these VMs is glacial.

If we track insertion points within the priority queue we can make savevm_state_handler_insert() a constant-time operation with little change to the module's code. Startup times for VMs with many handlers are dramatically improved as a result.

Changes since v1:
* Split patch 1 into 2 patches.

Scott Cheloha (2):
migration: add savevm_state_handler_remove()
migration: savevm_state_handler_insert: constant-time element
insertion

 migration/savevm.c | 35 ++++++++++++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 5 deletions(-)
Signature · 1 line
2.23.0