import x509/pkcs7 parsers from linux
Get series with b4
b4 am 20191018123523.GX16029@bill-the-catVersions newest first
- v1 Latest0 of 11 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 11 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux
Quoted 61 lines · AKASHI Takahiro
Hi Tom,
Quoted 18 lines · Tom Rini
Quoted 17 lines · AKASHI Takahiro
Quoted 15 lines · Heinrich Schuchardt
Quoted 6 lines · AKASHI Takahiro
Quoted 5 lines · Heinrich Schuchardt
Quoted 3 lines · AKASHI Takahiro
I hope this patch set will be reviewed promptly as I'm aiming to push my "UEFI secure boot" patch for v2020.01.
Quoted 6 lines
Quoted 2 lines
How can I make all of these new files being built to check for build warnings?
As always in my case of UEFI secure boot, they have gone through build and run/tests as part of UEFI secure boot. This is also true for RSA extension as UEFI secure boot is the only user of those features.
Did you run them through Travis?
Quoted 8 lines
Quoted 2 lines
As far as this patch set is concerned, no configuration enables any of kconfig options listed below and running Travis doesn't make sense.
That's a problem that needs to be fixed. I am not OK with the idea of adding a new feature that will not be put through our CI and so when things break it (which will happen, inadvertently) it won't be caught until much later. Figuring out how to extend our CI to test this is a must. Thanks!
I added a simple *unit* test under "test/lib."
As I said before, however, no existing configuration enables either
CONFIG_X509_CERTIFICATE_PARSER, norCONFIG_PKCS7_MESSAGE_PARSERand the related code won't be built or exercised in any way. So I made a small trick to
Kconfig:=== 8< ===
configUT_LIB
bool "Unit tests for library functions"
depends onUNIT_TEST
default y
help
Enables the 'ut lib' command which tests library functions likememcat(),memcyp(),memmove().if
UT_LIBconfig
UT_LIB_ASN1
bool "Unit test for asn1 compiler and decoder function" default y
implyASYMMETRIC_KEY_TYPE
implyASYMMETRIC_PUBLIC_KEY_SUBTYPE
implyX509_CERTIFICATE_PARSER
implyPKCS7_MESSAGE_PARSER
implyRSA_PUBLIC_KEY_PARSER
help
Enables a test which exercises asn1 compiler and decoder function via various parsers.
Quoted 8 lines
endif
=== >8 ===So as long as
UT_LIBis enabled and run by one of Travis CI test cases, a new test for ASN1 will also be exercised.
(I don't know which one will invoke "ut" command.)Do you agree to this approach?
I think you're going to need to get a bit more familiar with some aspects of testing and building. Today, CONFIG_UNIT_TEST is enabled for sandbox. And we want as much as possible enabled on sandbox as that's also where coverity scan is performed. So that will get us part of the way forward here longer term. I think however you're going to also need to enable some tests on the QEMU platforms so that we can have all of this new secure boot code put through CI there. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191018/69c91ac0/attachment.sig>