Skip to content

mc146818rtc: Allow call object_initialize(MC146818_RTC) instead of rtc_init()

Philippe Mathieu-Daudé qemu-devel 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4mc146818rtc: move structure to header filehw/timer/mc146818rtc.c include/hw/timer/mc146818rtc.h+33 -300 replies
2/4mc146818rtc: Move RTC_ISA_IRQ definitioninclude/hw/timer/mc146818rtc.h include/hw/timer/mc146818rtc_regs.h tests/rtc-test.c+3 -21 reply
3/4mc146818rtc: Include mc146818rtc_regs.h directly in mc146818rtc.chw/timer/mc146818rtc.c include/hw/timer/mc146818rtc.h+1 -10 replies
4/4mc146818rtc: always register rtc to rtc listhw/timer/mc146818rtc.c+2 -60 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchMichael S. TsirkinPaolo BonziniAleksandar MarkovicThomas Huth
1/4A-b A-b R-b
2/4R-b
3/4
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] mc146818rtc: Allow call object_initialize(MC146818_RTC) instead of rtc_init()

Four RTC146818 patches extracted from a bigger series:
"hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge"
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html

This step is required to be able to create a MC146818_RTC within a QOM object (which will be used in the "piix4: add a mc146818rtc controller" patch later).

No changes since previous post:

$ git backport-diff -u pc_split_i440fx_piix
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/4:[----] [--] 'mc146818rtc: move structure to header file' 002/4:[----] [--] 'mc146818rtc: Move RTC_ISA_IRQ definition'
003/4:[----] [--] 'mc146818rtc: Include "mc146818rtc_regs.h" directly in mc146818rtc.c' 004/4:[----] [--] 'mc146818rtc: always register rtc to rtc list'

Hervé Poussineau (2):
mc146818rtc: move structure to header file
mc146818rtc: always register rtc to rtc list

Philippe Mathieu-Daudé (2):
mc146818rtc: Move RTC_ISA_IRQ definition
mc146818rtc: Include mc146818rtc_regs.h directly in mc146818rtc.c

 hw/timer/mc146818rtc.c              | 39 +++--------------------------
 include/hw/timer/mc146818rtc.h      | 36 +++++++++++++++++++++++++-
 include/hw/timer/mc146818rtc_regs.h |  2 --
 tests/rtc-test.c                    |  1 +
 4 files changed, 39 insertions(+), 39 deletions(-)
Signature · 1 line
2.21.0