Skip to content

s390x/tcg: Vector instruction fixes

David Hildenbrand qemu-devel 2 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 4 repliesApplied
  2. v16 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- "s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION" -- Fix by inverting the result
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION"
-- Reuse gen_ac2_i64()
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION" -- Reuse gen_accc2_i64()
- Ran against more tests

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODDtarget/s390x/vec_int_helper.c+1 -10 replies
2/6s390x/tcg: Fix VECTOR MULTIPLY AND ADD *target/s390x/vec_int_helper.c+4 -40 replies
3/6s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTEtarget/s390x/vec_int_helper.c+4 -20 replies
4/6s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATIONtarget/s390x/translate_vx.inc.c target/s390x/vec_int_helper.c+5 -41 reply
5/6s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATIONtarget/s390x/translate_vx.inc.c+5 -51 reply
6/6s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATIONtarget/s390x/translate_vx.inc.c+3 -101 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] s390x/tcg: Vector instruction fixes

Ivan reported that a simple

    $ go get -v -d github.com/FactomProject/factom

Will result in errors when vector instructions are in use. Turns out golang makes excessive use of vector instructions, e.g., for crypto, hashes but also basic math.

I tracked the involved vector instructions and started writing more tests for them (will upstream them once they are in a better shape). Turns out there are quite some issues remaining. golang uses instructions not yet used by the kernel or by glibc.

With these patches, "go get" works again. It wouldn't surprise me if there are more BUGs in the vector instructions. Will continue writing more tests.

Cc Ivan Warren <[email protected]>

v1 -> v2:
- "s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION" -- Fix by inverting the result
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION"
-- Reuse gen_ac2_i64()
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION" -- Reuse gen_accc2_i64()
- Ran against more tests

David Hildenbrand (6):
s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD
s390x/tcg: Fix VECTOR MULTIPLY AND ADD *
s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION

 target/s390x/translate_vx.inc.c | 30 ++++++++++++------------------
 target/s390x/vec_int_helper.c   | 18 ++++++++++--------
 2 files changed, 22 insertions(+), 26 deletions(-)
Signature · 1 line
2.21.0