s390x/tcg: Vector instruction fixes
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 4 repliesApplied
- v16 patches 10 repliesSuperseded
Changes in v2 from the cover letter
- "s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION" -- Fix by inverting the result
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION"
-- Reuse gen_ac2_i64()
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION" -- Reuse gen_accc2_i64()
- Ran against more tests
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODDtarget/ | +1 | 0 replies | |
| 2/6 | s390x/tcg: Fix VECTOR MULTIPLY AND ADD *target/ | +4 | 0 replies | |
| 3/6 | s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTEtarget/ | +4 | 0 replies | |
| 4/6 | s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATIONtarget/ target/ | +5 | 1 reply | |
| 5/6 | s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATIONtarget/ | +5 | 1 reply | |
| 6/6 | s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATIONtarget/ | +3 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] s390x/tcg: Vector instruction fixes
Ivan reported that a simple
$ go get -v -d github.com/FactomProject/factom
Will result in errors when vector instructions are in use. Turns out golang makes excessive use of vector instructions, e.g., for crypto, hashes but also basic math.
I tracked the involved vector instructions and started writing more tests for them (will upstream them once they are in a better shape). Turns out there are quite some issues remaining. golang uses instructions not yet used by the kernel or by glibc.
With these patches, "go get" works again. It wouldn't surprise me if there are more BUGs in the vector instructions. Will continue writing more tests.
v1 -> v2:
- "s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION" -- Fix by inverting the result
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION"
-- Reuse gen_ac2_i64()
- "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION" -- Reuse gen_accc2_i64()
- Ran against more tests
David Hildenbrand (6):
s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD
s390x/tcg: Fix VECTOR MULTIPLY AND ADD *
s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION
target/s390x/translate_vx.inc.c | 30 ++++++++++++------------------ target/s390x/vec_int_helper.c | 18 ++++++++++-------- 2 files changed, 22 insertions(+), 26 deletions(-)
Signature · 1 line
2.21.0