Skip to content

mfd: rn5t618: Add RTC/ADC support

Andreas Kemnade linux-devicetree linux-iio linux-rtc lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 4 repliesIn review
  2. v6 posting 2/27 patches 3 repliesSuperseded
  3. v6 posting 1/27 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v5 posting 2/25 patches0 repliesSuperseded
v5 posting 1/25 patches3 repliesSuperseded
v45 patches10 repliesSuperseded
v36 patches11 repliesSuperseded
v25 patches7 repliesSuperseded
v15 patches13 repliesSuperseded

Changes in v7 from the cover letter

- cleanup in IRQ init stuff

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7dt-bindings: mfd: rn5t618: Document optional property interruptsDocumentation/devicetree/bindings/mfd/rn5t618.txt+4 -00 replies
2/7mfd: rn5t618: add IRQ supportdrivers/mfd/Kconfig drivers/mfd/rn5t618.c include/linux/mfd/rn5t618.h+93 -11 reply
3/7mfd: rn5t618: add RTC related registersdrivers/mfd/rn5t618.c include/linux/mfd/rn5t618.h+13 -00 replies
4/7mfd: rn5t618: add more subdevicesdrivers/mfd/rn5t618.c+18 -21 reply
5/7rtc: rc5t619: add Ricoh RC5T619 RTC driverdrivers/rtc/Kconfig drivers/rtc/Makefile drivers/rtc/rtc-rc5t619.c+455 -00 replies
6/7iio: adc: rn5t618: Add ADC driver for RN5T618/RC5T619drivers/iio/adc/Kconfig drivers/iio/adc/Makefile drivers/iio/adc/rn5t618-adc.c+267 -00 replies
7/7mfd: rn5t618: cleanup i2c_device_iddrivers/mfd/rn5t618.c+2 -91 reply

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchLee JonesRob HerringAlexandre BelloniJonathan Cameron
1/7Acked-for-MFD-by A-b
2/7Acked-for-MFD-by
3/7Acked-for-MFD-by
4/7Acked-for-MFD-by
5/7A-b
6/7R-b
7/7Acked-for-MFD-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/7] mfd: rn5t618: Add RTC/ADC support

In the variant RC5T619 the mfd has an RTC. This patchset adds support for it. To do so it adds the missing register defines in rn5t618.h and general irq handling for that.
It seems that the IRQ definitions are the same except missing RTC for the RN5T618 but due to missing ability to test that they are not added here.
It also adds support for the ADC, it is available in both the RN5T618 and RC5T619 but due to missing ability to test that, the subdevice is only added for the RC5T619.

It was tested on the Kobo Clara HD.

Changes in v7:
- cleanup in IRQ init stuff

Changes in v6:
- put together with ADC series
- also added cleanup i2_device_id patch to avoid merge conflicts

Changes in v5:
- static rn5t618_irq_init
- PLATFORM_DEVID_NONE
- added some Acked-Bys

Changes in v4:
- use macros for IRQ definitions
- merge rn5t618-core.c and rn5t618-irq.c

Changes in v3:
- alignment cleanup
- output cleanup, remove useless toggling of alarm flag in rtc probe
- updated bindings description, so patch 1/5 becomes 2/6 and so on

Changes in v2:
- no dead code in irq code
- various improvements and cleanups in rtc driver itself

Andreas Kemnade (7):
dt-bindings: mfd: rn5t618: Document optional property interrupts
mfd: rn5t618: add IRQ support
mfd: rn5t618: add RTC related registers
mfd: rn5t618: add more subdevices
rtc: rc5t619: add Ricoh RC5T619 RTC driver
iio: adc: rn5t618: Add ADC driver for RN5T618/RC5T619
mfd: rn5t618: cleanup i2c_device_id

 .../devicetree/bindings/mfd/rn5t618.txt       |   4 +
 drivers/iio/adc/Kconfig                       |  10 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/rn5t618-adc.c                 | 256 ++++++++++
 drivers/mfd/Kconfig                           |   1 +
 drivers/mfd/rn5t618.c                         | 109 ++++-
 drivers/rtc/Kconfig                           |  10 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-rc5t619.c                     | 444 ++++++++++++++++++
 include/linux/mfd/rn5t618.h                   |  26 +
 10 files changed, 851 insertions(+), 11 deletions(-)
 create mode 100644 drivers/iio/adc/rn5t618-adc.c
 create mode 100644 drivers/rtc/rtc-rc5t619.c
Signature · 1 line
2.20.1