Skip to content

virtiofs daemon (base)

Dr. David Alan Gilbert (git) qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest30 patches 30 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30virtiofsd: Pull in upstream headerscontrib/virtiofsd/fuse.h contrib/virtiofsd/fuse_common.h contrib/virtiofsd/fuse_i.h +5 more+4774 -00 replies
2/30virtiofsd: Pull in kernel's fuse.hcontrib/virtiofsd/fuse_kernel.h+858 -04 replies
3/30virtiofsd: Add auxiliary .c'scontrib/virtiofsd/buffer.c contrib/virtiofsd/fuse_log.c contrib/virtiofsd/fuse_loop_mt.c +3 more+1677 -00 replies
4/30virtiofsd: Add fuse_lowlevel.ccontrib/virtiofsd/fuse_lowlevel.c+3104 -02 replies
5/30virtiofsd: Add passthrough_llcontrib/virtiofsd/passthrough_ll.c+1322 -00 replies
6/30virtiofsd: Trim down imported filescontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_loop_mt.c contrib/virtiofsd/fuse_lowlevel.c +1 more+5 -11140 replies
7/30virtiofsd: remove mountpoint dummy argumentcontrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_lowlevel.h contrib/virtiofsd/helper.c +1 more+7 -320 replies
8/30virtiofsd: remove unused notify reply supportcontrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_lowlevel.h+1 -1880 replies
9/30virtiofsd: Fix fuse_daemonize ignored return valuescontrib/virtiofsd/helper.c+14 -110 replies
10/30virtiofsd: Fix common header and define for QEMU buildscontrib/virtiofsd/buffer.c contrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_loop_mt.c +4 more+8 -240 replies
11/30virtiofsd: fuse: Make iov_length usable outside fuse_lowlevel.ccontrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_lowlevel.h+10 -12 replies
12/30virtiofsd: Make fsync work even if only inode is passed incontrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/passthrough_ll.c+28 -50 replies
13/30virtiofsd: Add options for virtiocontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/helper.c+17 -120 replies
14/30virtiofsd: add -o source=PATH to help outputcontrib/virtiofsd/passthrough_ll.c+1 -00 replies
15/30virtiofsd: Open vhost connection instead of mountingcontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_virtio.c +1 more+110 -480 replies
16/30virtiofsd: Start wiring up vhost-usercontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_loop_mt.c contrib/virtiofsd/fuse_lowlevel.c +4 more+101 -50 replies
17/30virtiofsd: Add main virtio loopcontrib/virtiofsd/fuse_virtio.c+39 -33 replies
18/30virtiofsd: get/set features callbackscontrib/virtiofsd/fuse_virtio.c+14 -10 replies
19/30virtiofsd: Start queue threadscontrib/virtiofsd/fuse_virtio.c+89 -00 replies
20/30virtiofsd: Poll kick_fd for queuecontrib/virtiofsd/fuse_virtio.c+39 -10 replies
21/30virtiofsd: Start reading commands from queuecontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_virtio.c+98 -32 replies
22/30virtiofsd: Send replies to messagescontrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_virtio.c contrib/virtiofsd/fuse_virtio.h+111 -40 replies
23/30virtiofsd: Keep track of repliescontrib/virtiofsd/fuse_virtio.c+20 -30 replies
24/30virtiofsd: Add Makefile wiring for virtiofsd contribMakefile Makefile.objs contrib/virtiofsd/Makefile.objs+19 -00 replies
25/30virtiofsd: Fast path for virtio readcontrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_virtio.c contrib/virtiofsd/fuse_virtio.h+169 -00 replies
26/30virtiofsd: add --fd=FDNUM fd passing optioncontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_virtio.c+40 -130 replies
27/30virtiofsd: make -f (foreground) the defaultcontrib/virtiofsd/helper.c+6 -00 replies
28/30virtiofsd: add vhost-user.json file.gitignore Makefile contrib/virtiofsd/50-qemu-virtiofsd.json.in+7 -00 replies
29/30virtiofsd: add --print-capabilities optioncontrib/virtiofsd/fuse_lowlevel.h contrib/virtiofsd/helper.c contrib/virtiofsd/passthrough_ll.c +1 more+18 -10 replies
30/30virtiofs: Add maintainers entryMAINTAINERS+8 -00 replies

Reviews trailers per patch

3 of 30 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertMarc-André Lureau
1/30
2/30
3/30
4/30
5/30
6/30
7/30
8/30
9/30
10/30
11/30
12/30
13/30
14/30
15/30
16/30
17/30
18/30
19/30
20/30
21/30
22/30
23/30
24/30
25/30
26/30R-b
27/30
28/30R-b
29/30R-b
30/30

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/30] virtiofs daemon (base)

From: "Dr. David Alan Gilbert" <[email protected]>

Hi,
This is the 1st set for the virtiofsd - a daemon
that implements the user space side of virtiofs.

The kernel and qemu device parts recently went in,
so the daemon is the only thing missing to have a working set.

This set is the absolute minimal base set of patches;
it's not yet safe to use (from security or correctness);

I'll follow up with ~3 more series in the next few days with:

a) Security patches that add sandboxing and checking compared with normal fuse - that makes it safe.
b) Performance improvements including threading
c) Other fixes, including correctness.

but, this is a good start and gets things rolling.

The set pulls in a big chunk of the upstream libfuse library (unmodified so that it's easy to check it really is upstream), chops all the stuff out we don't need and then adds the new transport we need.

For new files I've formatted the code according to qemu standards; for files that are from upstream libfuse I've kept with their standards for ease of future updating.

We can't just link with libfuse, since we have to make ABI incompatible changes for the new transport.

Running this daemon is typically done with:

./virtiofsd -o vhost_user_socket=/path/socket -o source=/path/to/fs

connected to a qemu that's then started with:
-chardev socket,id=char0,path=/path/socket -device vhost-user-fs-pci,queue-size=1024,chardev=char0,tag=myfs

and then in the guest mount with:
mount -t virtiofs myfs /mnt

Our development branch is: https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev

Dave

Dr. David Alan Gilbert (22):
virtiofsd: Pull in upstream headers
virtiofsd: Pull in kernel's fuse.h
virtiofsd: Add auxiliary .c's
virtiofsd: Add fuse_lowlevel.c
virtiofsd: Add passthrough_ll
virtiofsd: Trim down imported files
virtiofsd: Fix fuse_daemonize ignored return values
virtiofsd: Fix common header and define for QEMU builds
virtiofsd: fuse: Make iov_length usable outside fuse_lowlevel.c
virtiofsd: Add options for virtio
virtiofsd: Open vhost connection instead of mounting
virtiofsd: Start wiring up vhost-user
virtiofsd: Add main virtio loop
virtiofsd: get/set features callbacks
virtiofsd: Start queue threads
virtiofsd: Poll kick_fd for queue
virtiofsd: Start reading commands from queue
virtiofsd: Send replies to messages
virtiofsd: Keep track of replies
virtiofsd: Add Makefile wiring for virtiofsd contrib
virtiofsd: Fast path for virtio read
virtiofs: Add maintainers entry

Stefan Hajnoczi (7):
virtiofsd: remove mountpoint dummy argument
virtiofsd: remove unused notify reply support
virtiofsd: add -o source=PATH to help output
virtiofsd: add --fd=FDNUM fd passing option
virtiofsd: make -f (foreground) the default
virtiofsd: add vhost-user.json file
virtiofsd: add --print-capabilities option

Vivek Goyal (1):
virtiofsd: Make fsync work even if only inode is passed in

 .gitignore                                  |    1 +
 MAINTAINERS                                 |    8 +
 Makefile                                    |    9 +
 Makefile.objs                               |    1 +
 contrib/virtiofsd/50-qemu-virtiofsd.json.in |    5 +
 contrib/virtiofsd/Makefile.objs             |   10 +
 contrib/virtiofsd/buffer.c                  |  318 +++
 contrib/virtiofsd/fuse.h                    | 1268 ++++++++++
 contrib/virtiofsd/fuse_common.h             |  823 +++++++
 contrib/virtiofsd/fuse_i.h                  |  131 ++
 contrib/virtiofsd/fuse_kernel.h             |  858 +++++++
 contrib/virtiofsd/fuse_log.c                |   40 +
 contrib/virtiofsd/fuse_log.h                |   82 +
 contrib/virtiofsd/fuse_loop_mt.c            |   54 +
 contrib/virtiofsd/fuse_lowlevel.c           | 2302 +++++++++++++++++++
 contrib/virtiofsd/fuse_lowlevel.h           | 2024 ++++++++++++++++
 contrib/virtiofsd/fuse_misc.h               |   59 +
 contrib/virtiofsd/fuse_opt.c                |  422 ++++
 contrib/virtiofsd/fuse_opt.h                |  271 +++
 contrib/virtiofsd/fuse_signals.c            |   90 +
 contrib/virtiofsd/fuse_virtio.c             |  717 ++++++
 contrib/virtiofsd/fuse_virtio.h             |   33 +
 contrib/virtiofsd/helper.c                  |  300 +++
 contrib/virtiofsd/passthrough_helpers.h     |   76 +
 contrib/virtiofsd/passthrough_ll.c          | 1341 +++++++++++
 docs/interop/vhost-user.json                |    4 +-
 26 files changed, 11246 insertions(+), 1 deletion(-)
 create mode 100644 contrib/virtiofsd/50-qemu-virtiofsd.json.in
 create mode 100644 contrib/virtiofsd/Makefile.objs
 create mode 100644 contrib/virtiofsd/buffer.c
 create mode 100644 contrib/virtiofsd/fuse.h
 create mode 100644 contrib/virtiofsd/fuse_common.h
 create mode 100644 contrib/virtiofsd/fuse_i.h
 create mode 100644 contrib/virtiofsd/fuse_kernel.h
 create mode 100644 contrib/virtiofsd/fuse_log.c
 create mode 100644 contrib/virtiofsd/fuse_log.h
 create mode 100644 contrib/virtiofsd/fuse_loop_mt.c
 create mode 100644 contrib/virtiofsd/fuse_lowlevel.c
 create mode 100644 contrib/virtiofsd/fuse_lowlevel.h
 create mode 100644 contrib/virtiofsd/fuse_misc.h
 create mode 100644 contrib/virtiofsd/fuse_opt.c
 create mode 100644 contrib/virtiofsd/fuse_opt.h
 create mode 100644 contrib/virtiofsd/fuse_signals.c
 create mode 100644 contrib/virtiofsd/fuse_virtio.c
 create mode 100644 contrib/virtiofsd/fuse_virtio.h
 create mode 100644 contrib/virtiofsd/helper.c
 create mode 100644 contrib/virtiofsd/passthrough_helpers.h
 create mode 100644 contrib/virtiofsd/passthrough_ll.c
Signature · 1 line
2.23.0