Skip to content

ICMP flow improvements

Matteo Croce lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 13 repliesIn review
  2. v14 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- remove unused struct members
- add an helper to check for the Id field
- use a local flow_dissector_key in the bonding to avoid changing behaviour of the flow dissector

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4flow_dissector: add meaningful commentsinclude/net/flow_dissector.h net/core/flow_dissector.c+7 -00 replies
2/4flow_dissector: skip the ICMP dissector for non ICMP packetsnet/core/flow_dissector.c+25 -90 replies
3/4flow_dissector: extract more ICMP informationinclude/net/flow_dissector.h net/core/flow_dissector.c+61 -320 replies
4/4bonding: balance ICMP echoes in layer3+4 modedrivers/net/bonding/bond_main.c+70 -712 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchNikolay Aleksandrov
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/4] ICMP flow improvements

This series improves the flow inspector handling of ICMP packets:
The first two patches just add some comments in the code which would have saved me a few minutes of time, and refactor a piece of code.
The third one adds to the flow inspector the capability to extract the Identifier field, if present, so echo requests and replies are classified as part of the same flow.
The fourth patch uses the function introduced earlier to the bonding driver, so echo replies can be balanced across bonding slaves.

v1 -> v2:
- remove unused struct members
- add an helper to check for the Id field
- use a local flow_dissector_key in the bonding to avoid changing behaviour of the flow dissector

Matteo Croce (4):
flow_dissector: add meaningful comments
flow_dissector: skip the ICMP dissector for non ICMP packets
flow_dissector: extract more ICMP information
bonding: balance ICMP echoes in layer3+4 mode

 drivers/net/bonding/bond_main.c |  77 ++++++++++++++++++++---
 include/net/flow_dissector.h    |  20 +++---
 net/core/flow_dissector.c       | 108 +++++++++++++++++++++++---------
 3 files changed, 160 insertions(+), 45 deletions(-)
Signature · 1 line
2.21.0