Skip to content

mm/gup_benchmark: fix MAP_HUGETLB case

John Hubbard linux-kselftest linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1mm/gup_benchmark: fix MAP_HUGETLB casetools/testing/selftests/vm/gup_benchmark.c+1 -15 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchJérôme Glisse
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] mm/gup_benchmark: fix MAP_HUGETLB case

Hi,

Here's another gup_benchmark.c fix, which I ran into while adding support for the upcoming FOLL_PIN work. Anyway, the problem is clearly described in the patch commit description, and the fix seems like the best way to me, but the fix is not *completely* black and white.

This fix forces MAP_ANONYMOUS for the MAP_HUGETLB case. However, another way to do it might be to mmap() against a valid hugetlb page file, instead of /dev/zero. But that seems like a lot of trouble and if I'm reading the intent correctly, MAP_ANONYMOUS is what's desired anyway.

John Hubbard (1):
mm/gup_benchmark: fix MAP_HUGETLB case

 tools/testing/selftests/vm/gup_benchmark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.23.0