Skip to content

import x509/pkcs7 parsers from linux

AKASHI Takahiro u-boot 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 0 repliesNew
  2. v2 posting 2/20 of 17 patches 0 repliesSuperseded
  3. v2 posting 1/217 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v10 of 11 patches0 repliesSuperseded

Changes in v3 from the cover letter

* rebased to v2020.01-rc
* improve function description of kmemdup() (patch#1)
* remove test/lib/Kconfig (patch#16)
* declare variables in unit test as static (patch#16)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16linux_compat: move kmemdup() from ubifs.c to linux_compat.cfs/ubifs/ubifs.c lib/linux_compat.c+20 -182 replies
2/16rtc.h: add struct udevice declarationinclude/rtc.h+2 -01 reply
3/16rtc: move date.c from drivers/rtc/ to lib/cmd/Kconfig drivers/rtc/Kconfig drivers/rtc/Makefile +3 more+9 -41 reply
4/16lib: add mktime64() for linux compatibilityinclude/linux/time.h lib/date.c+30 -01 reply
5/16include: kernel.h: include printk.hinclude/linux/kernel.h+1 -12 replies
5/16include: kernel.h: include printk.h+0 -00 replies
5/16include: kernel.h: include printk.h+0 -00 replies
6/16linux/time.h: include vsprintf.hinclude/linux/time.h+1 -03 replies
6/16linux/time.h: include vsprintf.h+0 -00 replies
7/16cmd: add asn1_compilerinclude/linux/asn1.h include/linux/asn1_ber_bytecode.h include/linux/asn1_decoder.h +4 more+1793 -21 reply
8/16Makefile: add build script for asn1 parsersMakefile scripts/Makefile.build+4 -11 reply
9/16lib: add asn1 decoderlib/Kconfig lib/Makefile lib/asn1_decoder.c+533 -01 reply
10/16doc: add README for asn1 compiler and decoderdoc/README.asn1+40 -01 reply
11/16lib: add oid registry utilityinclude/linux/oid_registry.h lib/Kconfig lib/Makefile +2 more+520 -01 reply
12/16lib: crypto: add public key utilityinclude/crypto/public_key.h include/keys/asymmetric-type.h lib/crypto/Kconfig +3 more+1251 -01 reply
13/16lib: crypto: add rsa public key parserinclude/crypto/internal/rsa.h lib/crypto/Kconfig lib/crypto/Makefile +2 more+281 -01 reply
14/16lib: crypto: add x509 parserlib/Kconfig lib/Makefile lib/crypto/Kconfig +6 more+1172 -03 replies
14/16lib: crypto: add x509 parser+0 -00 replies
15/16lib: crypto: add pkcs7 message parserinclude/crypto/pkcs7.h lib/crypto/Kconfig lib/crypto/Makefile +4 more+962 -31 reply
16/16test: add asn1 unit testtest/Kconfig test/lib/Makefile test/lib/asn1.c+410 -11 reply

Reviews trailers per patch

2 of 20 patches have a Reviewed-by or Acked-by.

PatchHeinrich Schuchardt
1/16R-b
2/16
3/16
4/16
5/16
5/16
5/16
6/16
6/16
7/16R-b
8/16
9/16
10/16
11/16
12/16
13/16
14/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [U-Boot] [PATCH v3 00/16] import x509/pkcs7 parsers from linux

# This patch set is a prerequisite for UEFI secure boot.
# This patch set should be merged first prior to my rsa extension patch

# due to some dependency.

Asn1 parsers of x509 certificates and pkcs7 messages are required to implement image authentication and variable authentication as part of UEFI secure boot feature.

As we discussed before in the thread[1], most people insisted that we should re-use corresponding source code from Linux repository for this purpose.

Here is my attempt to import all the necessary files from Linux; Those will eventually be part of UEFI secure boot implementation, but I'd like to get early feedback from other peoples before submitting the whole patchset so that they will be better formatted for merging.

My approach here is
* files from the latest Linux
* modify files as little as possible
* mark/protect unavoidable changes with "#if(n)def __UBOOT__" so that future fixes/differences in Linux repository will easily be applied to U-Boot.

Known issues:
* checkpatch.pl
Checkpatch.pl will complain with a bunch of warnings/errors but I intentionally left them unchanged for the sake of better maintainability I said above.

-Takahiro Akashi

[1] https://lists.denx.de/pipermail/u-boot/2019-April/366423.html

Changes in v3 (Nov 13, 2019)
* rebased to v2020.01-rc
* improve function description of kmemdup() (patch#1)
* remove test/lib/Kconfig (patch#16)
* declare variables in unit test as static (patch#16)

Changes in v2 (Oct 25, 2019)
* revise commit messages, describing what files are modified or not.
* move kmemdump() in ubifs.c to linux_compat.c for general use (patch#1)
* add patch#2
* move date.c to lib/ for general use (patch#3)
* implement mktime64() with rtc_mktime() (patch#4)
* move asn1_compiler.c to tools/ (patch#7)
* change CONFIG_BUILD_ASN1 to CONFIG_ASN1_COMPILER (patch#7)
* add clean rule to asn1_compiler-generated files to clean targets (patch#8)
* change CONFIG_ASN1 to CONFIG_ASN1_DECODER (patch#9)
* add README for asn1 compiler/decoder (patch#10)
* move build_oid_registry to scripts/ (patch#11)
* shuffle an order of patches (patch#13,#14,#15)
* add a new config CONFIG_RSA_PUBLIC_KEY_PARSER so that it can be
* modify Kconfig dependency (patch#13,#14,#15)
compiled in independently (patch#13)
* add unit test (patch#16,#17)

Changes in v1 (Oct 11, 2019) from RFC
* change the kernel code base from v5.0 to v5.3
* add preparatory patches (#1, #2 and #3)
* comment off x509_check_for_self_signed() which is not useful for UEFI secure boot (patch#9)
* improve usages of "#if(n)def __UBOOT__* to minimize differences between U-Boot and linux kernel

AKASHI Takahiro (16):
linux_compat: move kmemdup() from ubifs.c to linux_compat.c rtc.h: add struct udevice declaration
rtc: move date.c from drivers/rtc/ to lib/
lib: add mktime64() for linux compatibility
include: kernel.h: include printk.h
linux/time.h: include vsprintf.h
cmd: add asn1_compiler
Makefile: add build script for asn1 parsers
lib: add asn1 decoder
doc: add README for asn1 compiler and decoder
lib: add oid registry utility
lib: crypto: add public key utility
lib: crypto: add rsa public key parser
lib: crypto: add x509 parser
lib: crypto: add pkcs7 message parser
test: add asn1 unit test

 Makefile                          |    1 +
 cmd/Kconfig                       |    1 +
 doc/README.asn1                   |   40 +
 drivers/rtc/Kconfig               |    1 +
 drivers/rtc/Makefile              |    1 -
 fs/ubifs/ubifs.c                  |   19 +-
 include/crypto/internal/rsa.h     |   57 +
 include/crypto/pkcs7.h            |   47 +
 include/crypto/public_key.h       |   90 ++
 include/keys/asymmetric-type.h    |   88 ++
 include/linux/asn1.h              |   65 ++
 include/linux/asn1_ber_bytecode.h |   89 ++
 include/linux/asn1_decoder.h      |   20 +
 include/linux/kernel.h            |    2 +-
 include/linux/oid_registry.h      |  117 +++
 include/linux/time.h              |   11 +
 include/rtc.h                     |    2 +
 lib/Kconfig                       |   17 +
 lib/Makefile                      |   20 +
 lib/asn1_decoder.c                |  527 ++++++++++
 lib/crypto/Kconfig                |   52 +
 lib/crypto/Makefile               |   49 +
 lib/crypto/asymmetric_type.c      |  668 ++++++++++++
 lib/crypto/pkcs7.asn1             |  135 +++
 lib/crypto/pkcs7_parser.c         |  693 +++++++++++++
 lib/crypto/pkcs7_parser.h         |   65 ++
 lib/crypto/public_key.c           |  376 +++++++
 lib/crypto/rsa_helper.c           |  198 ++++
 lib/crypto/rsapubkey.asn1         |    4 +
 lib/crypto/x509.asn1              |   60 ++
 lib/crypto/x509_akid.asn1         |   35 +
 lib/crypto/x509_cert_parser.c     |  697 +++++++++++++
 lib/crypto/x509_parser.h          |   57 +
 lib/crypto/x509_public_key.c      |  292 ++++++
 {drivers/rtc => lib}/date.c       |   23 +-
 lib/linux_compat.c                |   19 +
 lib/oid_registry.c                |  179 ++++
 scripts/Makefile.build            |    4 +-
 scripts/build_OID_registry        |  203 ++++
 test/Kconfig                      |   18 +-
 test/lib/Makefile                 |    1 +
 test/lib/asn1.c                   |  392 +++++++
 tools/Makefile                    |    3 +
 tools/asn1_compiler.c             | 1611 +++++++++++++++++++++++++++++
 44 files changed, 7024 insertions(+), 25 deletions(-)
 create mode 100644 doc/README.asn1
 create mode 100644 include/crypto/internal/rsa.h
 create mode 100644 include/crypto/pkcs7.h
 create mode 100644 include/crypto/public_key.h
 create mode 100644 include/keys/asymmetric-type.h
 create mode 100644 include/linux/asn1.h
 create mode 100644 include/linux/asn1_ber_bytecode.h
 create mode 100644 include/linux/asn1_decoder.h
 create mode 100644 include/linux/oid_registry.h
 create mode 100644 lib/asn1_decoder.c
 create mode 100644 lib/crypto/Kconfig
 create mode 100644 lib/crypto/Makefile
 create mode 100644 lib/crypto/asymmetric_type.c
 create mode 100644 lib/crypto/pkcs7.asn1
 create mode 100644 lib/crypto/pkcs7_parser.c
 create mode 100644 lib/crypto/pkcs7_parser.h
 create mode 100644 lib/crypto/public_key.c
 create mode 100644 lib/crypto/rsa_helper.c
 create mode 100644 lib/crypto/rsapubkey.asn1
 create mode 100644 lib/crypto/x509.asn1
 create mode 100644 lib/crypto/x509_akid.asn1
 create mode 100644 lib/crypto/x509_cert_parser.c
 create mode 100644 lib/crypto/x509_parser.h
 create mode 100644 lib/crypto/x509_public_key.c
 rename {drivers/rtc => lib}/date.c (81%)
 create mode 100644 lib/oid_registry.c
 create mode 100755 scripts/build_OID_registry
 create mode 100644 test/lib/asn1.c
 create mode 100644 tools/asn1_compiler.c
Signature · 1 line
2.21.0