Skip to content

qcow2: Fix image corruption bug in 4.1

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v13 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- Dropped the assertion in qcow2_cache_do_get() for now. Making sure that it actually holds true for all callers requires more work and getting the corruption fix in quickly is important.

- Use atomic_read() and add comment to qemu_co_mutex_assert_locked() implementation [Denis]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2coroutine: Add qemu_co_mutex_assert_locked()include/qemu/coroutine.h+15 -02 replies
2/2qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation()block/qcow2-refcount.c block/qcow2.c+4 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVladimir Sementsov-OgievskiyDenis V. LunevMax ReitzMichael Weiser
SeriesR-b T-b
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] qcow2: Fix image corruption bug in 4.1

This series fixes an image corruption bug that was introduced in commit 69f47505e ('block: avoid recursive block_status call if possible'), first contained in the QEMU 4.1.0 release.

This bug was reported by Michael Weiser on Launchpad:
https://bugs.launchpad.net/qemu/+bug/1846427

v2:

- Dropped the assertion in qcow2_cache_do_get() for now. Making sure that it actually holds true for all callers requires more work and getting the corruption fix in quickly is important.

- Use atomic_read() and add comment to qemu_co_mutex_assert_locked() implementation [Denis]

Kevin Wolf (2):
coroutine: Add qemu_co_mutex_assert_locked()
qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation()

 include/qemu/coroutine.h | 15 +++++++++++++++
 block/qcow2-refcount.c   |  2 ++
 block/qcow2.c            |  3 ++-
 3 files changed, 19 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1