Remove data_len field from the nvmet_req struct
Status from this message: Thanks, applied to nvme-5.5 with the requested author attribution.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()drivers/ | +1 | 1 reply | |
| 2/7 | nvmet-tcp: Don't set the request's data_lendrivers/ | +2 | 1 reply | |
| 3/7 | nvmet: Introduce common execute function for get_log_page and identifydrivers/ | +50 | 5 replies | |
| 4/7 | nvmet: Cleanup discovery execute handlersdrivers/ | +19 | 0 replies | |
| 5/7 | nvmet: Introduce nvmet_dsm_len() helperdrivers/ drivers/ | +7 | 1 reply | |
| 6/7 | nvmet: Remove the data_len field from the nvmet_req structdrivers/ drivers/ drivers/ +4 more | +86 | 0 replies | |
| 7/7 | nvmet: Open code nvmet_req_execute()drivers/ drivers/ drivers/ +3 more | +8 | 1 reply |
Reviews trailers per patch
5 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Sagi Grimberg | Chaitanya Kulkarni | Christoph Hellwig |
|---|---|---|---|
| 1/7 | R-b | R-b | |
| 2/7 | R-b | ||
| 3/7 | R-b | ||
| 4/7 | |||
| 5/7 | R-b | ||
| 6/7 | |||
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/7] Remove data_len field from the nvmet_req struct
Hi,
This patchset is a cleanup in preparation for the passthru patchset. The aim is to remove the data_len field in the nvmet_req struct and instead just check the length is appropriate inside the execute handlers. This is more appropriate for passthru which may have commands with unknown lengths (like Vendor Specific Commands). It's also in improvement seeing it can often be confusing when it's best to use the data_len field over the transfer_len field. The first two patches in this series remove some questionable uses of the data_len field in nvmt-tcp
Most of this patchset was extracted from a draft patch from Christoph[1].
The series is based on v5.4-rc4 and a git branch is available here:
https://github.com/sbates130272/linux-p2pmem/branches nvmet_data_len
Logan
[1] https://lore.kernel.org/linux-block/[email protected]/
--
Logan Gunthorpe (7):
nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()
nvmet-tcp: Don't set the request's data_len
nvmet: Introduce common execute function for get_log_page and identify
nvmet: Cleanup discovery execute handlers
nvmet: Introduce nvmet_dsm_len() helper
nvmet: Remove the data_len field from the nvmet_req struct
nvmet: Open code nvmet_req_execute()
drivers/nvme/target/admin-cmd.c | 128 +++++++++++++++++------------- drivers/nvme/target/core.c | 12 +-- drivers/nvme/target/discovery.c | 62 +++++++-------- drivers/nvme/target/fabrics-cmd.c | 15 +++- drivers/nvme/target/fc.c | 4 +- drivers/nvme/target/io-cmd-bdev.c | 19 +++-- drivers/nvme/target/io-cmd-file.c | 20 +++-- drivers/nvme/target/loop.c | 2 +- drivers/nvme/target/nvmet.h | 10 ++- drivers/nvme/target/rdma.c | 4 +- drivers/nvme/target/tcp.c | 14 ++-- 11 files changed, 167 insertions(+), 123 deletions(-)
--
2.20.1