Skip to content

net: avoid KCSAN splats

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: add skb_queue_empty_lockless()include/linux/skbuff.h+24 -90 replies
2/5udp: use skb_queue_empty_lockless()net/ipv4/udp.c+3 -30 replies
3/5net: use skb_queue_empty_lockless() in poll() handlersdrivers/isdn/capi/capi.c net/atm/common.c net/bluetooth/af_bluetooth.c +11 more+22 -220 replies
4/5net: use skb_queue_empty_lockless() in busy poll contextsdrivers/crypto/chelsio/chtls/chtls_io.c drivers/nvme/host/tcp.c net/core/datagram.c +3 more+6 -60 replies
5/5net: add READ_ONCE() annotation in __skb_wait_for_more_packets()net/core/datagram.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/5] net: avoid KCSAN splats

Often times we use skb_queue_empty() without holding a lock, meaning that other cpus (or interrupt) can change the queue under us. This is fine, but we need to properly annotate the lockless intent to make sure the compiler wont over optimize things.

Eric Dumazet (5):
net: add skb_queue_empty_lockless()
udp: use skb_queue_empty_lockless()
net: use skb_queue_empty_lockless() in poll() handlers
net: use skb_queue_empty_lockless() in busy poll contexts
net: add READ_ONCE() annotation in __skb_wait_for_more_packets()

 drivers/crypto/chelsio/chtls/chtls_io.c |  2 +-
 drivers/isdn/capi/capi.c                |  2 +-
 drivers/nvme/host/tcp.c                 |  2 +-
 include/linux/skbuff.h                  | 33 ++++++++++++++++++-------
 net/atm/common.c                        |  2 +-
 net/bluetooth/af_bluetooth.c            |  4 +--
 net/caif/caif_socket.c                  |  2 +-
 net/core/datagram.c                     |  8 +++---
 net/core/sock.c                         |  2 +-
 net/decnet/af_decnet.c                  |  2 +-
 net/ipv4/tcp.c                          |  4 +--
 net/ipv4/udp.c                          |  8 +++---
 net/nfc/llcp_sock.c                     |  4 +--
 net/phonet/socket.c                     |  4 +--
 net/sctp/socket.c                       |  6 ++---
 net/tipc/socket.c                       |  4 +--
 net/unix/af_unix.c                      |  6 ++---
 net/vmw_vsock/af_vsock.c                |  2 +-
 18 files changed, 56 insertions(+), 41 deletions(-)
Signature · 1 line
2.23.0.866.gb869b98d4c-goog