Skip to content

virtiofs daemon (security)

Dr. David Alan Gilbert (git) qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest25 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25virtiofsd: passthrough_ll: create new files in caller's contextcontrib/virtiofsd/passthrough_ll.c+71 -40 replies
2/25virtiofsd: passthrough_ll: add lo_map for ino/fh indirectioncontrib/virtiofsd/passthrough_ll.c+113 -00 replies
3/25virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointerscontrib/virtiofsd/passthrough_ll.c+105 -200 replies
4/25virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointerscontrib/virtiofsd/passthrough_ll.c+75 -250 replies
5/25virtiofsd: passthrough_ll: add fd_map to hide file descriptorscontrib/virtiofsd/passthrough_ll.c+92 -210 replies
6/25virtiofsd: passthrough_ll: add fallback for racy opscontrib/virtiofsd/passthrough_ll.c+131 -180 replies
7/25virtiofsd: validate path componentscontrib/virtiofsd/passthrough_ll.c+53 -60 replies
8/25virtiofsd: Plumb fuse_bufvec through to do_write_bufcontrib/virtiofsd/fuse_i.h contrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_virtio.c+45 -270 replies
9/25virtiofsd: Pass write iov's all the way throughcontrib/virtiofsd/fuse_virtio.c+67 -60 replies
10/25virtiofsd: add fuse_mbuf_iter APIcontrib/virtiofsd/buffer.c contrib/virtiofsd/fuse_common.h+76 -00 replies
11/25virtiofsd: validate input buffer sizes in do_write_buf()contrib/virtiofsd/fuse_lowlevel.c+38 -240 replies
12/25virtiofsd: check input buffer size in fuse_lowlevel.c opscontrib/virtiofsd/fuse_lowlevel.c+482 -1390 replies
13/25virtiofsd: prevent ".." escape in lo_do_lookup()contrib/virtiofsd/passthrough_ll.c+6 -10 replies
14/25virtiofsd: prevent ".." escape in lo_do_readdir()contrib/virtiofsd/passthrough_ll.c+22 -140 replies
15/25virtiofsd: use /proc/self/fd/ O_PATH file descriptorcontrib/virtiofsd/passthrough_ll.c+101 -270 replies
16/25virtiofsd: sandbox mount namespacecontrib/virtiofsd/passthrough_ll.c+89 -00 replies
17/25virtiofsd: move to an empty network namespacecontrib/virtiofsd/passthrough_ll.c+14 -00 replies
18/25virtiofsd: move to a new pid namespacecontrib/virtiofsd/passthrough_ll.c+62 -140 replies
19/25virtiofsd: add seccomp whitelistcontrib/virtiofsd/Makefile.objs contrib/virtiofsd/passthrough_ll.c contrib/virtiofsd/seccomp.c +1 more+152 -10 replies
20/25virtiofsd: Parse flag FUSE_WRITE_KILL_PRIVcontrib/virtiofsd/fuse_common.h contrib/virtiofsd/fuse_lowlevel.c+7 -20 replies
21/25virtiofsd: Drop CAP_FSETID if client asked for itcontrib/virtiofsd/Makefile.objs contrib/virtiofsd/passthrough_ll.c+129 -00 replies
22/25virtiofsd: set maximum RLIMIT_NOFILE limitcontrib/virtiofsd/passthrough_ll.c+34 -00 replies
23/25virtiofsd: add security guide documentcontrib/virtiofsd/security.rst+108 -00 replies
24/25virtiofsd: add --syslog command-line optioncontrib/virtiofsd/fuse_lowlevel.h contrib/virtiofsd/helper.c contrib/virtiofsd/passthrough_ll.c +2 more+60 -130 replies
25/25virtiofsd: print log only when priority is high enoughcontrib/virtiofsd/fuse_log.c contrib/virtiofsd/fuse_lowlevel.c contrib/virtiofsd/fuse_lowlevel.h +2 more+91 -1020 replies

Reviews trailers per patch

3 of 25 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan Gilbert
1/25
2/25
3/25
4/25
5/25
6/25
7/25
8/25
9/25
10/25
11/25
12/25
13/25
14/25
15/25
16/25
17/25R-b
18/25
19/25
20/25
21/25R-b
22/25
23/25
24/25
25/25R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/25] virtiofs daemon (security)

From: "Dr. David Alan Gilbert" <[email protected]>

Hi,
This is the 2nd set for the virtiofsd - this set sits
on top of the 'base' set recently posted. Most of the changes in the set are security related (with a couple more tagging along because they were hard to separate).

Stefan's main chunks make the daemon check the input from
the guest; the upstream fuse code is much more trusting about what it gets from the kernel; here the security equation is inverted and the daemon is more trusted.
In adition the daemon now gets sandboxing/namespacing/seccomp
limited to stop anything escaping.

With this set virtiofsd is reasonably safe to use; we've
got some bug fixes (including some threading fixes) to send as well though.

Dave

Dr. David Alan Gilbert (2):
virtiofsd: Plumb fuse_bufvec through to do_write_buf
virtiofsd: Pass write iov's all the way through

Eryu Guan (1):
virtiofsd: print log only when priority is high enough

Miklos Szeredi (1):
virtiofsd: passthrough_ll: add fallback for racy ops

Stefan Hajnoczi (18):
virtiofsd: passthrough_ll: add lo_map for ino/fh indirection
virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointers
virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointers
virtiofsd: passthrough_ll: add fd_map to hide file descriptors
virtiofsd: validate path components
virtiofsd: add fuse_mbuf_iter API
virtiofsd: validate input buffer sizes in do_write_buf()
virtiofsd: check input buffer size in fuse_lowlevel.c ops
virtiofsd: prevent ".." escape in lo_do_lookup()
virtiofsd: prevent ".." escape in lo_do_readdir()
virtiofsd: use /proc/self/fd/ O_PATH file descriptor
virtiofsd: sandbox mount namespace
virtiofsd: move to an empty network namespace
virtiofsd: move to a new pid namespace
virtiofsd: add seccomp whitelist
virtiofsd: set maximum RLIMIT_NOFILE limit
virtiofsd: add security guide document
virtiofsd: add --syslog command-line option

Vivek Goyal (3):
virtiofsd: passthrough_ll: create new files in caller's context
virtiofsd: Parse flag FUSE_WRITE_KILL_PRIV
virtiofsd: Drop CAP_FSETID if client asked for it

 contrib/virtiofsd/Makefile.objs    |    7 +-
 contrib/virtiofsd/buffer.c         |   28 +
 contrib/virtiofsd/fuse_common.h    |   53 +-
 contrib/virtiofsd/fuse_i.h         |    2 +-
 contrib/virtiofsd/fuse_log.c       |    4 +
 contrib/virtiofsd/fuse_lowlevel.c  |  779 +++++++++++-----
 contrib/virtiofsd/fuse_lowlevel.h  |    2 +
 contrib/virtiofsd/fuse_virtio.c    |   72 +-
 contrib/virtiofsd/helper.c         |   11 +-
 contrib/virtiofsd/passthrough_ll.c | 1317 ++++++++++++++++++++++++----
 contrib/virtiofsd/seccomp.c        |  146 +++
 contrib/virtiofsd/seccomp.h        |   16 +
 contrib/virtiofsd/security.rst     |  108 +++
 13 files changed, 2152 insertions(+), 393 deletions(-)
 create mode 100644 contrib/virtiofsd/seccomp.c
 create mode 100644 contrib/virtiofsd/seccomp.h
 create mode 100644 contrib/virtiofsd/security.rst
Signature · 1 line
2.23.0