Skip to content

watchdog/softlockup: Report overall time and some cleanup

Petr Mladek lkml 1 version Applied

Status from this message: The following commit has been merged into the core/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3watchdog/softlockup: Remove obsolete check of last reported taskkernel/watchdog.c+1 -170 replies
2/3watchdog/softlockup: Report the overall time of softlockupskernel/watchdog.c+27 -102 replies
3/3watchdog/softlockup: Remove logic that tried to prevent repeated reportskernel/watchdog.c+2 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] watchdog/softlockup: Report overall time and some cleanup

This is rework of the softlockup improvements sent as
https://lkml.kernel.org/r/[email protected]
based on feedback from Peter Zijlstra.

+ merged the two patches
+ moved some cleanup changes into separate patches
+ improved the code and commit messages

The main change is in 2nd patch. It fixes the time spent in softlockup.

Original:

  [  168.277520] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [cat:4865]
  [  196.277604] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [cat:4865]
  [  236.277522] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [cat:4865]
                                                              ^^^

New:

  [  480.372418] watchdog: BUG: soft lockup - CPU#2 stuck for 26s! [cat:4943]
  [  508.372359] watchdog: BUG: soft lockup - CPU#2 stuck for 52s! [cat:4943]
  [  548.372359] watchdog: BUG: soft lockup - CPU#2 stuck for 89s! [cat:4943]
  [  576.372351] watchdog: BUG: soft lockup - CPU#2 stuck for 115s! [cat:4943]
                                                              ^^^^^

1st and 3rd patch clean up the code.

Petr Mladek (3):
watchdog/softlockup: Remove obsolete check of last reported task watchdog/softlockup: Report the overall time of softlockups watchdog/softlockup: Remove logic that tried to prevent repeated
reports

 kernel/watchdog.c | 67 ++++++++++++++++++++++++-------------------------------
 1 file changed, 29 insertions(+), 38 deletions(-)
Signature · 1 line
2.16.4