RFC xfs: automatic relogging experiment
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 RFC Latest10 patches 4 repliesIn review
- v5 RFC9 patches 49 repliesSuperseded
- v4 RFC2 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 RFC | 1 patch | 1 reply | Superseded | |
| v2 RFC | 3 patches | 0 replies | Superseded | |
| v1 RFC | 1 patch | 6 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | xfs: automatic relogging item managementfs/ fs/ fs/ +1 more | +27 | 0 replies | |
| 2/10 | xfs: create helper for ticket-less log res ungrantfs/ fs/ | +17 | 1 reply | |
| 3/10 | xfs: extra runtime reservation overhead for relog transactionsfs/ fs/ fs/ +3 more | +16 | 2 replies | |
| 4/10 | xfs: relog log reservation stealing and accountingfs/ fs/ fs/ +2 more | +56 | 0 replies | |
| 5/10 | xfs: automatic log item relog mechanismfs/ fs/ fs/ +2 more | +134 | 0 replies | |
| 6/10 | xfs: automatically relog the quotaoff start intentfs/ fs/ | +37 | 0 replies | |
| 7/10 | xfs: prevent fs freeze with outstanding relog itemsfs/ | +4 | 1 reply | |
| 8/10 | xfs: buffer relogging support prototypefs/ fs/ fs/ +1 more | +118 | 0 replies | |
| 9/10 | xfs: create an error tag for random relog reservationfs/ fs/ fs/ | +22 | 0 replies | |
| 10/10 | xfs: relog random buffers based on errortagfs/ fs/ fs/ +1 more | +51 | 0 replies |
Reviews trailers per patch
4 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Allison Collins |
|---|---|
| 1/10 | R-b |
| 2/10 | R-b |
| 3/10 | R-b |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | R-b |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC v6 PATCH 00/10] xfs: automatic relogging experiment
Hi all,
Here's a v6 of the automatic relogging RFC. The primary difference in this version is a rework of the relog reservation model based on design discussion on v5. Rather than roll existing transactions and initialize a fixed size relog transaction, this version acquires worst case relog reservation directly from the transactions that enable relog of log items. This facilitates construction of arbitrary combinations of items in the relog transaction without risk of deadlock due to log reservation and/or lock ordering. See the associated commit log for further details on the approach.
Beyond that, there are various other fixes and tweaks from v5. For example, the log item relog callback is used unconditionally and abstracts more of the reservation management code, buffer relogging is a bit more restrictive and reliable, various helpers are refactored, freeze is partly addressed, etc.
With regard to testing, this version survives a 1+ hour 80xcpu fsstress workload with random buffer relogging enabled without any notable issues and without observable reservation leaks. It also survives an fstests auto run without regression.
Patches 1-5 are preparatory patches and core mechanism. Patch 6 uses relogging to address the longstanding quotaoff deadlock problem. Patches 7-10 provide buffer relogging support and test code for DEBUG mode kernels to stress the relog mechanism via random buffer relogging.
Thoughts, reviews, flames appreciated.
Brian
rfcv6:
- Rework relog reservation model.
- Drop unnecessary log ticket t_task fix.
- Use ->iop_relog() callback unconditionally.
- Rudimentary freeze handling for random buffer relogging.
- Various other fixes, tweaks and cleanups.
rfcv5: https://lore.kernel.org/linux-xfs/[email protected]/
- More fleshed out design to prevent log reservation deadlock and locking problems.
- Split out core patches between pre-reservation management, relog item state management and relog mechanism.
- Added experimental buffer relogging capability.
rfcv4: https://lore.kernel.org/linux-xfs/[email protected]/
- AIL based approach.
rfcv3: https://lore.kernel.org/linux-xfs/[email protected]/
- CIL based approach.
rfcv2: https://lore.kernel.org/linux-xfs/[email protected]/
- Different approach based on workqueue and transaction rolling.
rfc: https://lore.kernel.org/linux-xfs/[email protected]/
Brian Foster (10):
xfs: automatic relogging item management
xfs: create helper for ticket-less log res ungrant
xfs: extra runtime reservation overhead for relog transactions
xfs: relog log reservation stealing and accounting
xfs: automatic log item relog mechanism
xfs: automatically relog the quotaoff start intent
xfs: prevent fs freeze with outstanding relog items
xfs: buffer relogging support prototype
xfs: create an error tag for random relog reservation
xfs: relog random buffers based on errortag
fs/xfs/libxfs/xfs_errortag.h | 4 +- fs/xfs/libxfs/xfs_shared.h | 1 + fs/xfs/xfs_buf.c | 4 + fs/xfs/xfs_buf_item.c | 52 ++++++++++++- fs/xfs/xfs_dquot_item.c | 26 +++++++ fs/xfs/xfs_error.c | 3 + fs/xfs/xfs_log.c | 35 +++++++-- fs/xfs/xfs_log.h | 4 +- fs/xfs/xfs_log_cil.c | 2 +- fs/xfs/xfs_log_priv.h | 1 + fs/xfs/xfs_qm_syscalls.c | 12 ++- fs/xfs/xfs_super.c | 4 + fs/xfs/xfs_trace.h | 4 + fs/xfs/xfs_trans.c | 75 ++++++++++++++++-- fs/xfs/xfs_trans.h | 36 ++++++++- fs/xfs/xfs_trans_ail.c | 146 ++++++++++++++++++++++++++++++++++- fs/xfs/xfs_trans_buf.c | 73 ++++++++++++++++++ fs/xfs/xfs_trans_priv.h | 20 +++++ 18 files changed, 477 insertions(+), 25 deletions(-)
Signature · 1 line
2.21.1