Skip to content

drm/udl: Convert to SHMEM

Thomas Zimmermann dri-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesIn review
  2. v24 patches 5 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v3 from the cover letter

* restore udl vmap function that enables caching

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/udl: Remove flags field from struct udl_gem_objectdrivers/gpu/drm/udl/udl_dmabuf.c drivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_gem.c+7 -250 replies
2/4drm/udl: Allocate GEM object via struct drm_driver.gem_create_objectdrivers/gpu/drm/udl/udl_drv.c drivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_gem.c+24 -40 replies
3/4drm/udl: Switch to SHMEMdrivers/gpu/drm/udl/Kconfig drivers/gpu/drm/udl/udl_drv.c drivers/gpu/drm/udl/udl_drv.h +2 more+138 -600 replies
4/4drm/udl: Remove struct udl_gem_object and functionsdrivers/gpu/drm/udl/Makefile drivers/gpu/drm/udl/udl_dmabuf.c drivers/gpu/drm/udl/udl_drv.h +1 more+1 -4900 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchGerd HoffmannZoltán Böszörményi
SeriesT-b
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] drm/udl: Convert to SHMEM

Udl's GEM implementation is mostly SHMEM and we should attempt to replace it with the latter.

Patches #1 and #2 update udl to simplify the conversion. In patch #3 the udl code is being replaced by SHMEM. The GEM object's mmap() and free_object() functions are wrappers around their SHMEM counterparts. For mmap() we fix-up the page-caching flags to distinguish between write-combined and cached access. For free(), we have to unmap the buffer's mapping that has been established by udl's fbdev code. Patch #4 removes the obsolete udl code.

The patchset has been tested by running the fbdev console, X11 and Weston on a DisplayLink adapter.

v3:
* restore udl vmap function that enables caching
v2:
* remove obsolete udl code in a separate patch

Thomas Zimmermann (4):
drm/udl: Remove flags field from struct udl_gem_object drm/udl: Allocate GEM object via struct drm_driver.gem_create_object drm/udl: Switch to SHMEM
drm/udl: Remove struct udl_gem_object and functions

 drivers/gpu/drm/udl/Kconfig      |   1 +
 drivers/gpu/drm/udl/Makefile     |   2 +-
 drivers/gpu/drm/udl/udl_dmabuf.c | 255 ------------------------------
 drivers/gpu/drm/udl/udl_drv.c    |  30 +---
 drivers/gpu/drm/udl/udl_drv.h    |  36 +----
 drivers/gpu/drm/udl/udl_fb.c     |  66 ++++----
 drivers/gpu/drm/udl/udl_gem.c    | 263 +++++++++----------------------
 7 files changed, 122 insertions(+), 531 deletions(-)
 delete mode 100644 drivers/gpu/drm/udl/udl_dmabuf.c

--
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel